Team east Sprint 1.39-2 bug bash

[mariusandra]

I had a look through the issues that just @joethreepwood and @corywatilo have posted, and found a lot of things we need to work on. Here's a loosely categorised list of bugs, mostly frontend, with 95% issues from from Joe and Cory. (Edit: and Chris)

Legend:
🐞 - bug with cause to investigate
⌨️ - ready to bash
🎨 - needs product design input
🏃 - in progress
🍩 - juicy feature
☠️ - has been attempted
🍯 - ooh, yummy
🐲 - here be dragons

Insights

• 🎨 🍩 Feature Request: View filters on shared insights #10211 - show filters in view mode
• ⌨️ Enhancement idea for trying to view a saved insight while signed in to a different account #10265 - better empty/unreachable state
• ⌨️ 🍩 Bug: Refusing to apply a sort filter on a breakdown table, applies the sort filter anyway #9570 Bug: Sorting a breakdown on an unsaved insight deletes the insight #9568 Clicking a column header asks me if I want to leave the page #10023 - sort filter on breakdown broken <- @pauldambra fix: table sorting during insight creation #11456
• ⌨️ Pre-populate existing tags #10678 - prepopulate list with existing tags
• 🐞 Reset button doesn't clear Compare Previous #5916 - compare previous doesn't reset @pauldambra
• ⌨️ Graph shows dates too far back #7840 - graphs go too far back

Filters

• 🏃 🍩 Get rid of propertyDefinitionModel and eventDefinitionModel #8257 - get rid of always loaded property definitions <-- feat(property-definitions): make propertyDefintionModel lazy #11454 feat(data-management): add custom events list #11463 refactor(frontend): remove eventDefintionsModel #11467 @mariusandra
• 🐞 🍩 Bug: First/Last Seen not loading on properties #10408 - last seen / first seen not showing
• 🐞 Event property "Last modified" date seems incorrect #11181 - last modified also not showing
• 🐞 🍩 Bug: Search bar for filter clips off screen  #11293 - taxonomic filter opens weird on small screens
• 🐞 Bug: Filter not showing fully #8564 - does not show property value select for multiple options
• 🏃 Option to duplicate a filter within a AND/OR group #11140 - button to duplicate OR filter (community contributor)
• ⌨️ Adding a filter takes two clicks when it could take one #9667 - add first filter with one click
• ⌨️ Query builder isn't showing filter name #9666 - add "..." better to large properties in select
• ⌨️ Return to custom date range panel when adjusting date range after already using custom date range =] #9664 - date filter custom range broken
• ⌨️ New date filter option: "Since..." #10727 - "date to now" option for filter
• ⌨️ 🍩 Feature: Event property filters for cohort creation #11142 - add property filters to cohorts, without bad workarounds
• ⌨️ 🍩 Can't query for pageviews on root domain #10798 - trailing slashes in url filters
• ⌨️ 🍩 🐲 The property filter pop-up closes if you change the selected property #7970 - filters close in a wonky way

Funnels

• 🎨 Design Feedback: Funnel creation #10144 - funnel creation dorky
• 🐞 Weird behavior when toggling funnel breakdown #10284 New Funnel Breakdowns show bars inconsistently #11349 - funnel breakdown acting weird
• 🐞 Relative values missing from left-to-right funnel layout #10226 - no relative values on left-to-right funnels
• 🎨 [Funnels] Remove preview pane before a 2nd step is added? #9115 - add funnel step is odd
• 🐞 Bug: Funnel insight not working L to R, but is working T to B #8517 - funnel bug.. is it still open?

Persons

• 🍩 🐞 PersonsModal has no results for day interval due to timezones #11466 @benjackwhite
  • 🐞 Bug: Unique persons not loading on Trends #9565 - persons not loading @benjackwhite
  • 🍩 Persons Modal for Filters shows only one page of persons #11352 - persons modal doesn't show all persons @benjackwhite
  • ⌨️ 🍩 styling on insight persons modal is off on chrome #11480 - updated persons modal to fix layout regressions @benjackwhite

Settings

• ⌨️ 🍩 Clean up task for authorized domains / urls #10229 - separate toolbar and recording URLs

Visualizations

• ⌨️ Feature Request - % of total Area chart #11276 - % of total area
• ⌨️ Tooltip overflow or truncation #9662 - tooltips look squished
• ⌨️ 🍩 Graph shows inaccurate data when using a grouping that exceeds the selected date range #9663 - better labels for months, or only select full months?
• 🎨 Change date format #4154 - change date format
• 🐞 Bug: Lifecycle report elements sometimes not clickable, highlights acting weird #7468 - lifecycle report is weird

Visualizations - can these be linked better?

• 🎨 Retention table styling update #11427
• 🎨 Pie chart styling update  #11433
• 🎨 Custom time legends (see artboard)

Tables technical improvements

• ⌨️ Enhancement: Feature Flag table doesn't wrap content or tags #10813 - wrapping the table for feature flags - @pauldambra
• ⌨️ 🍩 ☠️ 🍯 Feature request: Sticky first column in breakdown views #9567 - sticky first column
• ⌨️ 🍩 ☠️ 🍯 Feature request: Horizontal scrolling for breakdown charts #9566 - horizontal scrolling

Tables UX issues

• ⌨️ Incorrect column alignment on cohorts table #10228 - cohorts table alignment
• ⌨️ Column sorting icon isn't intuitive #11146 - last total sum column has a bad button for sort
• ⌨️ Table sorting (by sum) doesn't work by default, not preserved when changing date range #8408 - more problems with that column
• ⌨️ User properties table malformed #10595 - user properties table looks bad
• ⌨️ Make the experiments table sortable by more than just the creator column #10227 - make experiments table sortable

Other UX issues

• ⌨️ Bug: Correlation Analysis details not closing UI element #10275 - modal weird in correlation analysis
• ⌨️ Updated placement of register and sign in links for authentication #9520 - register and signin placement
• 🎨 Too many failed login attempts blocks app for all users + bad error ux #4885 - too many login requests breaks frontend (no nice error)
• ⌨️ Dismissible banners continue to show after page reloads #11475

Dashboards

• 🍩 Request: Time-editable Dashboards for Collaboration #8460 - edit time for one insight on a dashboard
• ⌨️ Show funnel conversion rate in dashboard cards #10264 - funnel conversion rate in card
• 🐞 Dashboard insights don't update after changing insight definition #10263 - tiles don't update if you edit insight descriptions
• 🎨 Change CTA for adding insights to dashboard #10262 - improve "add first insight" CTA
• ⌨️ 🍩 Dashboard descriptions can extend to page-level actions #9241 - dashboard descriptions extend too far
• ⌨️ Incorrect icon used to remove collaborators from a dashboard #9239 - wrong icon + button with no permission to click it <- fix: dashboard sharing UI don't use red for remove collaborator #11457 @pauldambra
• 🐲 add to dashboard bugs #10759 - multi dashboard caching

Annotations

• ☠️ 🍩 🍯 🐲 Bug: Annotations not appearing in correct place on timescale #9511 - annotations are off
• ☠️ 🍩 🍯 Annotations not displaying correctly in saved insight #11136 - annotations
• ☠️ 🍩 Annotations aren't plotting correctly on graphs with lots of plots #7841 - same
• ☠️ Improve annotation UX in insights #9058 - bad UX
• ⌨️ New annotation modal too narrow #8568 - too narrow
• ⌨️ Action conflict when an annotation exists for the first point on a time axis #11453 - first point in time can't show existing annotations

Actions & data management

• 🐞 Data quality issues after creating actions, then trying to create an insight #11076 - data quality issues with actions
• 🐞 Missing recently created actions/insights until refreshing the app #10783 - actions don't refresh in the app on edit
• 🐞 🍩 Re-run query when a graphed action's steps changes #4506 - modified actions won't refresh charts used by them
• 🎨 Show more metadata for actions #10723 - show more metadata
• 🎨 Add prompt about losing form changes when editing an action #10677 - not clear if we click on save or not
• 🎨 Buttons in "Create new action" modal getting clipped #10260 - create new action toolbar modal design broken
• 🐞 Action redefinition not working #4507 - weird field dynamics
• 🎨 "Verify event definition" option #4505 - verify that actions match events without saving
• 🎨 UX of actions match groups #4503 - can't remove fields from actions
• ⌨️ Don't show blank description text when not editable #10218 - bad blank text

CSV

• 🎨 Request: Let me choose which columns to export as CSV #9086 - choose columns to export
• 🍩 Request: Item count on CSV export #9084 - item count on CSVs
• 🍩 Feature Request: Count of items in a filtered list #10410 - how many people are in a list?

Toolbar

• 🎨 "Add match group to existing action" #11138 - add as match group to existing action
• ⌨️ Toolbar prompt partially obscured by scroll bar #4497 - toolbar goes behind scrollbar
• ⌨️ Toast issue in Toolbar #10846 - broken toast
• 🐞 🐲 No matching events for action defined with Toolbar #10796 - can't save something
• ⌨️ Option to add action metadata when defining an action with Toolbar #10679 - add tags and descriptions to actions
• 🐞 Console error when defining an action with toolbar #9286 - something breaks
• ⌨️ Hide Toolbar when not called on #6420 - follows me around - @pauldambra

Forms & accessibility

• ⌨️ Accessibility improvement - use label elements to reference form inputs #10335 - use label elements

Web performance

• 🏃 Icon position regression - Web performance #11337 - Icon position regression

Apps

• 🎨 Feature Request: Sync the App Libraries #10181 - sync app libraries on app and posthog.com
• ⌨️ Request: Mailchimp Connector App #9838 - req: mailchimp connector app
• 🎨 Bug: Plugin Icon Missing Pub/Sub #7012 - pubsub plugin icon - @pauldambra

Billing

• 🎨 Bug + Feedback: Billing prompt in Paths #9886 - billing prompt. fixed?
• ⌨️ Renaming plans to match new pricing page #10862 - renaming billing plans in app

Session Recordings

• 🐞 Session recording doesn't render webfonts? #9647 - custom fonts in session recordings?

Data quality

• ⌨️ [Breakdown by device] Non-mobile devices are poorly labeled #7795 - non-mobile devices are "none"

Out of scope new features

• 🇳🇿 Onboarding 1.5 emails #9784 - re-engagement emails for onboarding
• 🇳🇿 Feature Request: Ability to link to feature #9509 - link to areas of product
• 🇳🇿 Correlation analysis for cohorts #7875 - correlation analysis for cohorts
• 🇳🇿 Ability to comment on saved insights #10320 - add comments on saved insights
• 🇳🇿 Productizing in-product announcements #3150 - productize in-person announcements
• 🇳🇿 Animating the nav menu icons #9061 - animate sidebar icons
• 🏃 Demo Environvment: Onboarding #10193 - demo environment tutorial walkthough

Needs thought

• ❓ Feature Request: Tagging for Apps with issues #10322 - tag plugins with known issues
• ❓ Design: Hotkeys #6406 - expose hotkeys somewhere

I believe we have some work to do 😅. The next step is to Eisenhower the list above, and figure out the urgent/important split

[neilkakkar]

re: The FF enabled/disabled task: We're going to take that on next week for our FF UX changes :)

1 down, 89 to go, you're welcome 😋

[joethreepwood]

#9481 can be closed, as @lottiecoxon did that a little while ago.

88 issues left.

[clarkus]

I worked through my list of open issues in an attempt to find stuff that would have an impact and is also ready for work. I tried to focus on bugs, but there are also small improvements in the list. Here's what I have:

• Icon position regression - Web performance #11337
• Accessibility improvement - use label elements to reference form inputs #10335
• Incorrect column alignment on cohorts table #10228
• Make the experiments table sortable by more than just the creator column #10227
• Relative values missing from left-to-right funnel layout #10226
• Updated placement of register and sign in links for authentication #9520
• Dashboard descriptions can extend to page-level actions #9241
• Incorrect icon used to remove collaborators from a dashboard #9239

[mariusandra]

Thanks @clarkus, I added them all to the list above.

Team, keep in mind everyone that nothing is prioritised at this point... and we still have the rest of this sprint to finish 🙃.

Also keep in mind that even though every 5 solved bugs will get you a special surprise, and we will have some bugs that give bonus points, this is not a competition you should gamify. Not at all, nope.

I'll start Monday with further prioritising the list above according to Eisenhower, and definitely not ranking bugs by amount of golden coins you get for each.

Feel free to start Monday with whatever you find most impactful yourself.

[pauldambra]

I think we should probably have this bug on here multi-dashboard turbo mode confusion

[mariusandra]

I moved the bugs over to a project: https://github.com/orgs/PostHog/projects/58/views/1

Let's continue there!