styling on insight persons modal is off on chrome

[camerondeleone]

Bug description

scroll bars currently display on insight person modal, interfering with recordings. This used to render properly

Please describe.
If this affects the front-end, screenshots would be of great help.

How to reproduce

1. on latest chrome build, open insight person modal. happ[ens regardless of zoom

Environment

• PostHog Cloud
• self-hosted PostHog, version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!

[clarkus]

This feature is in need of a clean up. The recordings drop down is also broken - any person with multiple recordings gets a drop down to access each recording. Clicking this action places the dropdown in the upper left of the viewport - almost as if its relative positioning has changed somehow. The components used in the actions are also misaligned to our current pattern.

I redrew the modal to align with our current patterns. This should unblock any work we want to do to clean this up. Note that this area is going to be impacted by an upcoming iteration on recordings.

[camerondeleone]

That looks great @clarkus

Unrelated, but we should totally refactor this query to order by recordings present so it's convenient for users and we get fewer questions about 'why don't i see recordings here'. (somewhat related to monetizing session recordings cc @rcmarron )

[clarkus]

Nice idea. I'll add a sort option.

[benjackwhite]

This is great timing as I'm currently refactoring this component (it's a mess).

[rcmarron]

we get fewer questions about 'why don't i see recordings here'.

@camerondeleone are you hearing that question a lot? Adding a sort to that query is going to slow it down a good amount (because it's actually 2 separate queries at work here to avoid joining the tables). I'd be inclined to solve that question through messaging. Maybe a "Some users don't have recordings? Understand why." and it links to the docs?

[camerondeleone]

Ah, makes sense on the query. I don't hear it often enough to change the query just for that specific complaint (and even if I did, I'm conscious of the fact that more of my time is spent talking to new or onboarding users vs those happily paying us and power-using). What got me thinking of this was seeing how few recordings are consumed via /insights relative to /recordings and /home, and how if we can get people using that endpoint, it'll be quite sticky (bc no one else does that). And that people might not even know because idk if we guarantee the first x visible persons have a recording. We should ideally guarantee we show at least a couple if we have them. (Often this is the case).

On Thu, Aug 25, 2022 at 10:32 AM Rick Marron ***@***.***> wrote: we get fewer questions about 'why don't i see recordings here'. @camerondeleone <https://github.com/camerondeleone> are you hearing that question a lot? Adding a sort to that query is going to slow it down a good amount (because it's actually 2 separate queries at work here to avoid joining the tables). I'd be inclined to solve that question through messaging. Maybe a "Some users don't have recordings? Understand why." and it links to the docs? — Reply to this email directly, view it on GitHub <#11480 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANNN7TDZIJEXQY2H6PCEKG3V257YXANCNFSM57QSTTIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Cameron DeLeone Customer Success @ PostHog <https://posthog.com/> Book 30 minutes with me <https://calendly.com/cameron-posthog/30min-1>

[clarkus]

I will hold off on adding the sort option. 😃

[benjackwhite]

Closed because of a merge but it was behind a flag so I'll leave this open until its truly out