Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvement - use label elements to reference form inputs #10335

Closed
clarkus opened this issue Jun 16, 2022 · 2 comments
Closed
Labels
bug Something isn't working right feature/lemon-ui stale

Comments

@clarkus
Copy link
Contributor

clarkus commented Jun 16, 2022

Is your feature request related to a problem?

We have a lot of forms in our product. Very few of them use label elements. This is a usability and an accessibility issue. A label acts as extra affordance for a form input, but also offers an easy way to focus the corresponding input.

Describe the solution you'd like

Instead of using divs, use a label element with a for attribute that references the corresponding form element. This is showing up all over the place in our product. Maybe it's a result of the framework we're using for some interface components, but this is something we should try to fix sooner than later. It will cause major usability problems for some users.

This is really basic best practice for implementing form elements. I think we should treat this as a higher priority side quest for an upcoming sprint.

Describe alternatives you've considered

  • I don't think there's an alternative. We should do this.

Additional context

Thank you for your feature request – we love each and every one!

@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Contributor

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

@posthog-bot posthog-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right feature/lemon-ui stale
Projects
Development

No branches or pull requests

2 participants