fix: table sorting during insight creation #11456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 tasks
benjackwhite
requested changes
Aug 24, 2022
Comment on lines
310
to
311
| const useURLForSorting = !!insightProps.dashboardItemId && !insightProps.dashboardItemId.startsWith('new') | ||
|
|
There was a problem hiding this comment.
I think the overall solution makes sense but I wonder if here it makes more sense to use the "editing" mode as the flag rather than the "new" check (if that is possible) as otherwise this remains broken when editing an Insight
There was a problem hiding this comment.
I would have put money on testing that but it turns out that :homer-hege.gif: is appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sorting the insight table changes the URL. While editing a new insight this causes the protection against navigating away from the unsaved URL to fire.
We don't store the sort order on the insight itself so don't need to persist sorting during insight creation
closes #9570
closes #9568
closes #10023
Changes
LemonTableto not store sort order on the URLafter
How did you test this code?
Running it locally and seeing it work