Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismissible banners continue to show after page reloads #11475

Closed
2 tasks
clarkus opened this issue Aug 24, 2022 · 4 comments
Closed
2 tasks

Dismissible banners continue to show after page reloads #11475

clarkus opened this issue Aug 24, 2022 · 4 comments
Assignees
@Nike682631
Labels
bug Something isn't working right feature/lemon-ui good first issue Good for newcomers

Comments

@clarkus
Copy link
Contributor

clarkus commented Aug 24, 2022

Bug description

Dismissible banners reappear after being dismissed.

Screen.Recording.2022-08-24.at.9.46.41.AM.mov

How to reproduce

  1. Find a page with a dismissible banner on it (see data management)
  2. Dismiss the banner
  3. Reload the page
  4. Note that the banner persists

Environment

  • PostHog Cloud
  • self-hosted PostHog, version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!
@clarkus clarkus added bug Something isn't working right good first issue Good for newcomers feature/lemon-ui labels Aug 24, 2022
@clarkus clarkus mentioned this issue Aug 24, 2022
Closed
91 tasks
@Nike682631
Copy link

@clarkus is this issue available to work on?

@clarkus
Copy link
Contributor Author

clarkus commented Aug 25, 2022

@clarkus is this issue available to work on?

Yes. If you'd like to work on it, feel free to assign it to yourself and get started. Thanks!

@Nike682631
Copy link

I would probably need you to assign it to me. I don't have enough access rights for it.

@Twixes
Copy link
Member

Twixes commented Oct 11, 2022

This particular case is gone now. I agree we should be more mindful of this in the future.

@Twixes Twixes closed this as completed Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nike682631 Nike682631

Labels
bug Something isn't working right feature/lemon-ui good first issue Good for newcomers
Projects
Team App East Squish-Squash 🐛
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clarkus @Twixes @Nike682631