Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect icon used to remove collaborators from a dashboard #9239

Closed
clarkus opened this issue Mar 24, 2022 · 0 comments · Fixed by #11457
Closed

Incorrect icon used to remove collaborators from a dashboard #9239

clarkus opened this issue Mar 24, 2022 · 0 comments · Fixed by #11457
Labels
bug Something isn't working right feature/dashboards Feature Tag: Dashboards

Comments

@clarkus
Copy link
Contributor

clarkus commented Mar 24, 2022

Bug description

To remove a user from a shared dashboard, you click on a red x icon. This doesn't really align with any other interface in the product. The action is non-destructive as we're just removing a reference, not destroying data.

Secondarily, these actions are shown to all users. We shouldn't expose remove actions to users who don't have permission to use those actions.

The original concept allowed for changing permission types along with removing the user via the same component.

Screen Shot 2022-03-24 at 9 05 33 AM

Expected behavior

Use the icon we use in other similar scenarios and use a non-destructive palette option. Only show removal actions to the users who have permission to manage sharing for the dashboard. Until we allow for more granular control of collaborators, let's revisit this to use the same remove icons we use in other list views. We can also describe the icon with a tooltip to make it clear what the action does.

Screen Shot 2022-03-24 at 9 13 55 AM

How to reproduce

  1. Go to a dashboard with multiple collaborators
  2. Click share
  3. View the list of users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right feature/dashboards Feature Tag: Dashboards
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant