Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashboard sharing UI don't use red for remove collaborator #11457

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

pauldambra
Copy link
Member

Problem

closes #9239

Changes

  • removes some styles by using utility classes
  • removes grey background from collaborator rows
  • uses tertiary primary-alt for remove collaborator buttons
  • don't show a remove collaborator button if you can't remove the collaborator

2022-08-24 08 51 55

How did you test this code?

running it locally and seeing it happen

@pauldambra pauldambra requested a review from clarkus August 24, 2022 07:56
@pauldambra pauldambra mentioned this pull request Aug 24, 2022
91 tasks
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Twixes
Copy link
Member

Twixes commented Aug 24, 2022

This is looking pretty good, though a couple of things about the design irk me:

  1. There are two styles of subheadings in this modal – "Collaborators" should use the same style as "Project members with access":
    Screen Shot 2022-08-24 at 12 39 48
  2. I can see the motivation to center things behind this padding, but when I opened the modal "can edit" looked kind of misaligned to me:
    Screen Shot 2022-08-24 at 12 33 00

@pauldambra
Copy link
Member Author

Updated @Twixes

Screenshot 2022-08-24 at 11 55 16

@Twixes
Copy link
Member

Twixes commented Aug 24, 2022

It irks less now, thanks! 😄 I'll let @clarkus have the final word just in case.

@pauldambra pauldambra merged commit 6ea255a into master Aug 24, 2022
@pauldambra pauldambra deleted the fix/dashboard-sharing-ui branch August 24, 2022 17:03
pauldambra added a commit that referenced this pull request Aug 24, 2022
* fix: dashboard sharing UI don't use red for remove collaborator

* remove that which irks
@pauldambra pauldambra added the release-1.39.0 To be cherry-picked into `release-1.39.0` label Aug 24, 2022
@pauldambra
Copy link
Member Author

cherry-picked into 1.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-1.39.0 To be cherry-picked into `release-1.39.0`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect icon used to remove collaborators from a dashboard
4 participants