Bug: Correlation Analysis details not closing UI element

[joethreepwood]

Bug description

Then I click for detail on a correlation analysis result, this is what I see:

Blacking out the background and creating a pop-up I can understand, but leaving the 'View correlation details' box popped up and in-focus seems like a mistake.

How to reproduce

Environment

• PostHog Cloud
• self-hosted PostHog (ClickHouse-based), version/commit: please provide
• self-hosted PostHog (Postgres-based, legacy), version/commit: please provide

Additional context

Thank you for your bug report – we love squashing them!

[clarkus]

This is definitely deviating from our other overlay patterns. The overlay should be semi-transparent, and the modal should be aligned to other modal instances. Here's a redraw that aligns the content to other modal examples. I removed the footer as it always adds up to 100%, so didn't feel like it was adding much.

[AsiwajuDev]

@clarkus I picked up this issue and tried recreating the issue but no luck yet. Can you help by sharing the steps to recreate it?

[neilkakkar]

Go to a funnel -> add events -> scroll down to correlation table -> click three dots at the rightmost end of the table -> click 'view correlation details' -> see the above happen.

[AsiwajuDev]

@clarkus how do I get to locate a funnel

[neilkakkar]

Insights -> funnels

[AsiwajuDev]

@neilkakkar The experience is different for me on my side.

I see this on the insight page. I open one of the items, I have to click edit on the inner page and then navigate to the funnel tab but I do not see correlation table option

[neilkakkar]

Hey @AsiwajuDev , my bad, didn't realise this was an enterprise feature 😅 . I'd recommend switching to another issue. Something labelled good first issue is ideal: https://github.com/PostHog/posthog/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22