Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add match group to existing action" #11138

Closed
corywatilo opened this issue Aug 4, 2022 · 4 comments
Closed

"Add match group to existing action" #11138

corywatilo opened this issue Aug 4, 2022 · 4 comments
Labels
enhancement New feature or request feature/actions Feature Tag: Actions feature/data-management Feature Tag: Data management (fka Taxonomy) feature/toolbar Feature Tag: Toolbar stale

Comments

@corywatilo
Copy link
Contributor

Is your feature request related to a problem?

I have an established action, but the DOM structure where the action is being tracked recently changed. Since I don't want to lose the action's historical data, I want to add another DOM element to an existing action (as a match group).

Describe the solution you'd like

This can be done in the Data Management section, but it would be far more elegant to create it using the Toolbar.

An option to add a new match group to the Inspect tool should do the trick. (Not great design, but added a button as an example...) After this screen, there'd be a search field to find the existing action I want to add the match group to.

image

@corywatilo corywatilo added enhancement New feature or request feature/toolbar Feature Tag: Toolbar labels Aug 4, 2022
@clarkus
Copy link
Contributor

clarkus commented Aug 4, 2022

This is a really interesting use case. Should the previous matching criteria for the action no longer apply? Are we replacing that old criteria, adding another capture case, or something else I'm not thinking of? Do we need any way to indicate which criteria were used for the match when viewing the corresponding data?

@clarkus clarkus added feature/actions Feature Tag: Actions feature/data-management Feature Tag: Data management (fka Taxonomy) labels Aug 4, 2022
@corywatilo
Copy link
Contributor Author

Actually this is an interesting question: if I remove the old selector, does it remove the data from appearing for that action, or will it stay there since it was already recorded? (I had assumed if I removed the old selector, that the data would no longer match.)

For this particular use case, I want to retain historical data while capturing new data, so I don't actually care if it's indicated.

@posthog-bot
Copy link
Contributor

This issue hasn't seen activity in two years! If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

@posthog-bot
Copy link
Contributor

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature/actions Feature Tag: Actions feature/data-management Feature Tag: Data management (fka Taxonomy) feature/toolbar Feature Tag: Toolbar stale
Development

No branches or pull requests

3 participants