Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast issue in Toolbar #10846

Closed
corywatilo opened this issue Jul 18, 2022 · 3 comments · Fixed by #11494
Closed

Toast issue in Toolbar #10846

corywatilo opened this issue Jul 18, 2022 · 3 comments · Fixed by #11494
Labels
bug Something isn't working right feature/lemon-ui feature/toolbar Feature Tag: Toolbar

Comments

@corywatilo
Copy link
Contributor

After saving actions, it looks like a toast notification shows up, but it's hard to read. And sometimes doesn't ever go away.

image

Repro

Define a couple actions in a row using the Inspect tool

@corywatilo corywatilo added the feature/toolbar Feature Tag: Toolbar label Jul 18, 2022
@clarkus clarkus added bug Something isn't working right feature/lemon-ui labels Jul 19, 2022
@pauldambra
Copy link
Member

pauldambra commented Aug 24, 2022

Screenshot 2022-08-24 at 20 55 57

current theory: css variables assigned to :root are not available to the toolbar in its shadow root

@pauldambra
Copy link
Member

Hmmm.. toolbar.css opens

@charset "UTF-8";:root {
    --toastify-color-light: #fff;
    --toastify-color-dark: #121212;

the missing new line might be the fault there

@pauldambra
Copy link
Member

built CSS for toolbar declares root variables twice... once from /* node_modules/react-toastify/dist/ReactToastify.css */ and once from /* frontend/src/styles/global.scss */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right feature/lemon-ui feature/toolbar Feature Tag: Toolbar
Projects
Development

Successfully merging a pull request may close this issue.

3 participants