Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sdk-cpp: conan v2 support #17125

Merged
merged 17 commits into from
Sep 6, 2023
Merged

aws-sdk-cpp: conan v2 support #17125

merged 17 commits into from
Sep 6, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 19, 2023 •
edited
Loading

Will likely require all these PRs first:

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request May 5, 2023
Closed
@jiaoew1991 jiaoew1991 mentioned this pull request May 12, 2023
Closed
1 task
@jiaoew1991
Copy link
Contributor

Hi @SpaceIm , Could you change these PR lists to checkboxes? It looks more intuitive that way.

@conan-center-bot

This comment has been minimized.

Sign in to view
@CLAassistant
Copy link

CLAassistant commented May 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SpaceIm SpaceIm mentioned this pull request Jun 8, 2023
Merged
3 tasks
@mpimenov mpimenov mentioned this pull request Jun 8, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Aug 24, 2023
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 5a98674
aws-sdk-cpp/1.8.130@#aba4f3599d5e99548fdad2a0aa7816a9 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libaws-cpp-sdk-text-to-speech.dylib' links to system library 'AudioToolbox' but it is not in cpp_info.frameworks.
aws-sdk-cpp/1.9.234@#ed496f801bee339d566493456b4c2735 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libaws-cpp-sdk-text-to-speech.dylib' links to system library 'AudioToolbox' but it is not in cpp_info.frameworks.
aws-sdk-cpp/1.9.100@#96ae5fb795c43154e458b3e1aad6fbb2 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libaws-cpp-sdk-text-to-speech.dylib' links to system library 'AudioToolbox' but it is not in cpp_info.frameworks.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Aug 30, 2023

@jcar87 @RubenRBS @uilianries @prince-chrismc Finally it passes, could you review please?

@uilianries
Copy link
Member

Hello @SpaceIm I know @jcar87 was doing some tests with some AWS dependencies last week. Maybe he has some insight now.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (8d58fb3bda1ccac1f07564e4ee6eba55163ae646):

  • aws-sdk-cpp/1.9.100:
    All packages built successfully! (All logs)

  • aws-sdk-cpp/1.9.234:
    All packages built successfully! (All logs)

  • aws-sdk-cpp/1.8.130:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (8d58fb3bda1ccac1f07564e4ee6eba55163ae646):

  • aws-sdk-cpp/1.9.234:
    All packages built successfully! (All logs)

  • aws-sdk-cpp/1.9.100:
    All packages built successfully! (All logs)

  • aws-sdk-cpp/1.8.130:
    All packages built successfully! (All logs)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Hooks produced the following warnings for commit 8d58fb3
aws-sdk-cpp/1.9.100@#7433c6ad66ebf15c7de1f5a2e5eb3fb9 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libaws-cpp-sdk-text-to-speech.dylib' links to system library 'AudioToolbox' but it is not in cpp_info.frameworks.
aws-sdk-cpp/1.9.234@#0ad8828e94ec4025c17631a41f62e629 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libaws-cpp-sdk-text-to-speech.dylib' links to system library 'AudioToolbox' but it is not in cpp_info.frameworks.
aws-sdk-cpp/1.8.130@#c7e932af47042da49fbda88bf2aa4133 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libaws-cpp-sdk-text-to-speech.dylib' links to system library 'AudioToolbox' but it is not in cpp_info.frameworks.

This was referenced Sep 6, 2023
Closed
Closed
@ghost
Copy link

ghost commented Sep 6, 2023

I detected other pull requests that are modifying aws-sdk-cpp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

uilianries
uilianries reviewed Sep 6, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'll ping @jcar87 in case he has another opinion.

uilianries
uilianries approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go!

@conan-center-bot conan-center-bot merged commit 39bad72 into conan-io:master Sep 6, 2023
@SpaceIm SpaceIm deleted the aws-sdk-cpp-conan-v2 branch September 6, 2023 17:50
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Sep 15, 2023
@SpaceIm @jcar87 @ericLemanissier
(conan-io#17125) aws-sdk-cpp: conan v2 support
a491a91 
* conan v2 support

* use rm_safe to delete s3-crt option

* use cache_variables

* use preprocessor_definitions

* aws-c-event-stream is always a direct dependency

* disable warnings as errors

* aws-checksums is a direct dependency

* restore compatible versions of dependencies

* restore cmake_minimum_required to satisfy stupid hook

* fix build_modules

* fix requires in package_info()

* fix pulseaudio detection

* Add missing transitive headers, fix cmake modules

* use version range for openssl

* bump libcurl

* add version range for libcurl

---------

Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@gjasny gjasny gjasny left review comments

@jwillikers jwillikers jwillikers approved these changes

@mpimenov mpimenov mpimenov approved these changes

@gegles gegles gegles approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.