aws-c-s3: add missing interface definition if shared + modernize more for conan v2

[SpaceIm]

see https://github.com/awslabs/aws-c-s3/blob/v0.2.8/include/aws/s3/exports.h

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[SpaceIm]

waiting for #17104, #17105, #17107, #17108 & #17119

[CLAassistant]

All committers have signed the CLA.

[ghost]

I detected other pull requests that are modifying aws-c-s3/all recipe:

• aws-c-s3: add package_type #18200

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[mpimenov]

@jcar87 Please take a look

[SpaceIm]

In aws-c-s3/0.1.29, if apple-clang with conan v2:

[100%] Linking C shared library libaws-c-s3.dylib
Undefined symbols for architecture x86_64:
  "_aws_md5_compute", referenced from:
      _aws_s3_message_util_add_content_md5_header in s3_request_messages.c.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I've not tested locally, but shared build of 0.1.49 works fine for me.

[gjasny]

The aws-c-s3 package directly uses functions provided by aws-c-cal and therefore should explicitly create a dependency on it. With the following change both: 0.1.29 and 0.1.49 build on macOS with shared library support:

diff --git a/recipes/aws-c-s3/all/conanfile.py b/recipes/aws-c-s3/all/conanfile.py
index b63b926fa..f63d8e59f 100644
--- a/recipes/aws-c-s3/all/conanfile.py
+++ b/recipes/aws-c-s3/all/conanfile.py
@@ -43,10 +43,12 @@ class AwsCS3(ConanFile):
         self.requires("aws-c-common/0.8.2", transitive_headers=True, transitive_libs=True)
         if Version(self.version) < "0.1.49":
             self.requires("aws-c-auth/0.6.11", transitive_headers=True)
+            self.requires("aws-c-cal/0.5.13")
             self.requires("aws-c-http/0.6.13")
             self.requires("aws-c-io/0.10.20", transitive_headers=True)
         else:
             self.requires("aws-c-auth/0.6.17", transitive_headers=True)
+            self.requires("aws-c-cal/0.5.13")
             self.requires("aws-c-http/0.6.22")
             self.requires("aws-c-io/0.13.4", transitive_headers=True)
         if Version(self.version) >= "0.1.36":

[jcar87]

Relaunched CI jobs for this PR, will check later to complete the review.

[SpaceIm]

There is no dependency to asw-c-cal before 0.1.20 (there is still 0.1.19 in conandata): awslabs/aws-c-s3#48

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 7 (5221bee9bec22114e3a5a9dcef148b328c8f4c50):

• aws-c-s3/0.1.29:
  All packages built successfully! (All logs)

• aws-c-s3/0.1.27:
  All packages built successfully! (All logs)

• aws-c-s3/0.1.37:
  All packages built successfully! (All logs)

• aws-c-s3/0.1.49:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 7 (5221bee9bec22114e3a5a9dcef148b328c8f4c50):

• aws-c-s3/0.1.49:
  All packages built successfully! (All logs)

• aws-c-s3/0.1.37:
  All packages built successfully! (All logs)

• aws-c-s3/0.1.29:
  All packages built successfully! (All logs)

• aws-c-s3/0.1.27:
  All packages built successfully! (All logs)