Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-checksums: add missing interface definition if shared + modernize more for conan v2 #17119

Merged
merged 3 commits into from
Apr 28, 2023
Merged

aws-checksums: add missing interface definition if shared + modernize more for conan v2 #17119

merged 3 commits into from
Apr 28, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 19, 2023

see https://github.com/awslabs/aws-checksums/blob/v0.1.14/include/aws/checksums/exports.h

@prince-chrismc prince-chrismc mentioned this pull request Apr 19, 2023
Open
@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
Merged
13 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (03c9adffc78a8de80524942325b39b4bcc26a1e4):

  • aws-checksums/0.1.12@:
    All packages built successfully! (All logs)

  • aws-checksums/0.1.13@:
    All packages built successfully! (All logs)

  • aws-checksums/0.1.11@:
    All packages built successfully! (All logs)

  • aws-checksums/0.1.5@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 2 (03c9adffc78a8de80524942325b39b4bcc26a1e4):

  • aws-checksums/0.1.13@:
    All packages built successfully! (All logs)

  • aws-checksums/0.1.11@:
    All packages built successfully! (All logs)

  • aws-checksums/0.1.5@:
    All packages built successfully! (All logs)

  • aws-checksums/0.1.12@:
    All packages built successfully! (All logs)

This was referenced Apr 20, 2023
Merged
Merged
Merged
@conan-center-bot conan-center-bot merged commit 9491838 into conan-io:master Apr 28, 2023
@SpaceIm SpaceIm deleted the aws-checksums-dllimport branch April 28, 2023 22:19
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
@SpaceIm @pezy
(conan-io#17119) aws-checksums: add missing interface definition if s…
2f1473f 
…hared + modernize more for conan v2

* add AWS_CHECKSUMS_USE_IMPORT_EXPORT interface definition if shared

* modernize more

* more elegant way to define target for legacy generators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @prince-chrismc @jwillikers