New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-crt-cpp: add missing interface definition if shared #17120

Merged

conan-center-bot merged 5 commits into conan-io:master from SpaceIm:aws-crt-cpp-dllimport

Aug 30, 2023

Contributor

SpaceIm commented Apr 19, 2023 •

edited

Loading

see https://github.com/awslabs/aws-crt-cpp/blob/v0.19.9/include/aws/crt/Exports.h

closes #17382

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.


          add AWS_CRT_CPP_USE_IMPORT_EXPORT interface definition if shared

7c07500

conan-center-bot added the Failed label

This comment has been minimized.

Sign in to view


          more elegant way to define target for legacy generators

13fe9e4

conan-center-bot added Unexpected Error and removed Failed labels

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added Failed and removed Unexpected Error labels

This comment has been minimized.

Sign in to view

SpaceIm mentioned this pull request

aws-sdk-cpp: conan v2 support #17125

Merged

13 tasks


          add missing transitive headers

d7f9f36

This comment has been minimized.

Sign in to view

SpaceIm added 2 commits

April 21, 2023 00:48


          aws-c-common is a public dependency

a0209de


          fix traits

ac94233

This comment has been minimized.

Sign in to view

Contributor Author

SpaceIm commented Apr 20, 2023

waiting for #17100, #17104, #17105, #17107, #17108, #17110, #17111, #17117 & #17119

SpaceIm mentioned this pull request

[aws-crt-cpp] aws-crt-cpp/0.17.23: Builds fails due to using aws-c-common component that no longer exists #17382

Closed

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

CLAassistant commented May 18, 2023 •

edited

Loading

All committers have signed the CLA.

SpaceIm mentioned this pull request

aws-c-io: fix interface definition for shared lib on windows + bump s2n + add package_type #17104

Merged

3 tasks

jwillikers approved these changes

View reviewed changes

mpimenov approved these changes

View reviewed changes

recipes/aws-crt-cpp/all/conanfile.py

@@ @@ -46,22 +47,23 @@ def layout(self): @@
                       cmake_layout(self, src_folder="src")
                   def requirements(self):
-                      self.requires("aws-c-common/0.8.2")
+                      self.requires("aws-c-cal/0.5.13", transitive_headers=True)

Contributor

mpimenov Jun 8, 2023

Out of curiosity — can these transitive_headers additions be dropped after all libraries from #17125 are aligned?

Contributor Author

SpaceIm Jun 8, 2023

No, these headers are really transitive.

conan-center-bot added Unexpected Error and removed Failed labels

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request

Change approvals to include reviewer tier prince-chrismc/conan-center-index-pending-review#130

Merged

conan-center-bot removed the Unexpected Error label

conan-center-bot added the Failed label

This comment has been minimized.

Sign in to view

jcar87 self-assigned this

Contributor

mpimenov commented Jul 21, 2023

@jcar87 Could you look at this please?

conan-center-bot added Service Under Maintenance and removed Failed labels

This comment has been minimized.

Sign in to view

Contributor

jcar87 commented Aug 17, 2023

Relaunched CI jobs for this, will check later to complete the review.

conan-center-bot added Failed and removed Service Under Maintenance labels

This comment has been minimized.

Sign in to view

Contributor

jcar87 commented Aug 23, 2023

Waiting for #17117 to be merged before starting this one.

SpaceIm closed this

SpaceIm reopened this

This comment has been minimized.

Sign in to view

Contributor

jcar87 commented Aug 25, 2023

Relaunched job after promotion of missing packages

Contributor Author

SpaceIm commented Aug 25, 2023

Thanks

This comment has been minimized.

Sign in to view

Contributor

mpimenov commented Aug 27, 2023

Any progress on the review? This is the last one blocking #17125

SpaceIm closed this

SpaceIm reopened this

conan-center-bot removed the Failed label

Collaborator

conan-center-bot commented Aug 27, 2023

Conan v1 pipeline ✔️

All green in build 6 (ac94233345843eff33b945bde3968a96d12f2f41):

aws-crt-cpp/0.18.8:
All packages built successfully! (All logs)
aws-crt-cpp/0.17.12:
All packages built successfully! (All logs)
aws-crt-cpp/0.17.23:
All packages built successfully! (All logs)
aws-crt-cpp/0.14.3:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 6 (ac94233345843eff33b945bde3968a96d12f2f41):

aws-crt-cpp/0.18.8:
All packages built successfully! (All logs)
aws-crt-cpp/0.17.12:
All packages built successfully! (All logs)
aws-crt-cpp/0.17.23:
All packages built successfully! (All logs)
aws-crt-cpp/0.14.3:
All packages built successfully! (All logs)

Contributor Author

SpaceIm commented Aug 29, 2023

@jcar87 @uilianries @prince-chrismc @RubenRBS could you review please?

uilianries approved these changes

View reviewed changes

Member

uilianries left a comment

LGTM

conan-center-bot merged commit 26d01f8 into conan-io:master

SpaceIm deleted the aws-crt-cpp-dllimport branch

August 30, 2023 11:21

ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request


          (conan-io#17120) aws-crt-cpp: add missing interface definition if shared

d396952

* add AWS_CRT_CPP_USE_IMPORT_EXPORT interface definition if shared

* more elegant way to define target for legacy generators

* add missing transitive headers

* aws-c-common is a public dependency

* fix traits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet