-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-c-common: add AWS_COMMON_USE_IMPORT_EXPORT interface definition if shared #17105
aws-c-common: add AWS_COMMON_USE_IMPORT_EXPORT interface definition if shared #17105
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Please refer to the "consuming recipes" docs for how to enable revisions and store your own copies of recipes In ConanCenter we can only do one at a time :) so it will take a while for the rest of the AWS family to get updated |
Yes sorry for that. Maybe it could have been done in 2 steps to avoid breakage but it would have been super tedious (keep component and not define AWS for cmake_find_package & cmake_find_package_multi in each aws recipe, and do not depend anymore on component explicitly, then few weeks later remove component in each recipe). These recipes could be updated very quickly, I've opened PRs for each aws recipe 2 weeks ago, they build fine locally after updates on macOS, Linux & Windows. They are just waiting for reviewers. |
No problem, thanks @SpaceIm and @prince-chrismc. I'm sticking to the previous revisions while it's in progress |
…face definition if shared * add AWS_COMMON_USE_IMPORT_EXPORT interface definition if shared * more elegant way to define target for legacy generators * typo
see https://github.com/awslabs/aws-c-common/blob/v0.8.17/include/aws/common/exports.h