Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-c-common: add AWS_COMMON_USE_IMPORT_EXPORT interface definition if shared #17105

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 18, 2023

see https://github.com/awslabs/aws-c-common/blob/v0.8.17/include/aws/common/exports.h


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
13 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (e8a1e1c5d6af167bd4edc984f62953d1174c872f):

  • aws-c-common/0.7.0@:
    All packages built successfully! (All logs)

  • aws-c-common/0.8.2@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.9@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.2@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.20@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.11@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.4@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.3@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.7@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.14@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.15@:
    All packages built successfully! (All logs)

  • aws-c-common/0.4.25@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.1@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.17@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.8@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.5@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.19@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 3 (e8a1e1c5d6af167bd4edc984f62953d1174c872f):

  • aws-c-common/0.7.4@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.19@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.2@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.11@:
    All packages built successfully! (All logs)

  • aws-c-common/0.8.2@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.5@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.3@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.1@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.7@:
    All packages built successfully! (All logs)

  • aws-c-common/0.7.0@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.14@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.15@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.17@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.9@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.8@:
    All packages built successfully! (All logs)

  • aws-c-common/0.6.20@:
    All packages built successfully! (All logs)

  • aws-c-common/0.4.25@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 430521e into conan-io:master Apr 28, 2023
@SpaceIm SpaceIm deleted the aws-c-common-dllimport branch April 28, 2023 05:16
@cardinotGV
Copy link

This is breaking most of the other aws-* as they look for aws-c-common::aws-c-common-lib

(msvc)
image

@prince-chrismc
Copy link
Contributor

Please refer to the "consuming recipes" docs for how to enable revisions and store your own copies of recipes
https://github.com/conan-io/conan-center-index/blob/master/docs/consuming_recipes.md

In ConanCenter we can only do one at a time :) so it will take a while for the rest of the AWS family to get updated

@SpaceIm
Copy link
Contributor Author

SpaceIm commented May 3, 2023

Yes sorry for that. Maybe it could have been done in 2 steps to avoid breakage but it would have been super tedious (keep component and not define AWS for cmake_find_package & cmake_find_package_multi in each aws recipe, and do not depend anymore on component explicitly, then few weeks later remove component in each recipe). These recipes could be updated very quickly, I've opened PRs for each aws recipe 2 weeks ago, they build fine locally after updates on macOS, Linux & Windows. They are just waiting for reviewers.

@cardinotGV
Copy link

No problem, thanks @SpaceIm and @prince-chrismc. I'm sticking to the previous revisions while it's in progress

pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
…face definition if shared

* add AWS_COMMON_USE_IMPORT_EXPORT interface definition if shared

* more elegant way to define target for legacy generators

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants