Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-c-http: add missing interface definition if shared + modernize more for conan v2 #17107

Merged
merged 4 commits into from
Jun 20, 2023
Merged

aws-c-http: add missing interface definition if shared + modernize more for conan v2 #17107

merged 4 commits into from
Jun 20, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 18, 2023

see https://github.com/awslabs/aws-c-http/blob/v0.7.7/include/aws/http/exports.h

Without this fix, the build of aws-c-auth "all shared" fails with msvc.

@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 18, 2023 •
edited
Loading 

ERROR: Conflict in s2n/1.3.15:
    's2n/1.3.15' requires 'openssl/3.1.0' while 'aws-c-cal/0.5.13' requires 'openssl/1.1.1s'.
    To fix this conflict you need to override the package 'openssl' in your root package.

Waiting for #17100 (but also #17104, #17105 & #17109)

@SpaceIm SpaceIm force-pushed the aws-c-http-dllimport branch from 3f75baf to ca045fa Compare April 18, 2023 22:26
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
Merged
13 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Apr 20, 2023
Merged
Merged
Merged
Merged
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request May 5, 2023
Closed
@CLAassistant
Copy link

CLAassistant commented May 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SpaceIm SpaceIm mentioned this pull request Jun 8, 2023
Merged
3 tasks
@SpaceIm SpaceIm closed this Jun 8, 2023
@SpaceIm SpaceIm reopened this Jun 8, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 6 (b798e804accc1377072759779bf27580ac0da207):

  • aws-c-http/0.6.22@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.13@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.7@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.5@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.10@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 5 (b798e804accc1377072759779bf27580ac0da207):

  • aws-c-http/0.6.13@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.22@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.7@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.10@:
    All packages built successfully! (All logs)

  • aws-c-http/0.6.5@:
    All packages built successfully! (All logs)

@prince-chrismc prince-chrismc mentioned this pull request Jun 12, 2023
Open
uilianries
uilianries approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit bdfc966 into conan-io:master Jun 20, 2023
@SpaceIm SpaceIm deleted the aws-c-http-dllimport branch June 20, 2023 11:23
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
@SpaceIm @pezy
(conan-io#17107) aws-c-http: add missing interface definition if shar…
7341a16 
…ed + modernize more for conan v2

* add AWS_HTTP_USE_IMPORT_EXPORT interface definition if shared

* modernize more

* more elegant way to define target for legacy generators

* aws-c-common & aws-c-io are public dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@mpimenov mpimenov mpimenov approved these changes

@uilianries uilianries uilianries approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SpaceIm @conan-center-bot @CLAassistant @uilianries @mpimenov @jwillikers