-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-c-cal: modernize more for conan v2 + bump openssl #17100
aws-c-cal: modernize more for conan v2 + bump openssl #17100
Conversation
SpaceIm
commented
Apr 18, 2023
- conan v2:
- fix windows/shared (protect double deletion of fPIC)
- fix test package (logic based on self.user_info can't work for conan v2, and it was anyway wrong to define this user_info for the sole purpose of test package)
- bump openssl to 3.x
- I've read the contributing guidelines.
- I've used a recent Conan client version close to the currently deployed.
- I've tried at least one configuration locally with the conan-center hook activated.
This comment has been minimized.
This comment has been minimized.
I explicitly link |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
v2 pipeline, all shared:
I link |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 13 (
Conan v2 pipeline ✔️
All green in build 12 (
|
@uilianries @jcar87 @RubenRBS @danimtb Could you review please? This PR is mandatory for other aws recipe PRs opened for more than 1 month, and ultimately for PR providing v2 support to aws-sdk-cpp (and also fix #17382). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* bump openssl * modernize more for conan v2 * restore test of libcrypto * aws-c-common public headers are included by aws-c-cal public headers * link aws-c-common in test package * add AWS_CAL_USE_IMPORT_EXPORT interface definition if shared * modernize a little bit more * more elegant way to define target for legacy generators * add transitive_libs to aws-c-common * use version range for openssl
* bump openssl * modernize more for conan v2 * restore test of libcrypto * aws-c-common public headers are included by aws-c-cal public headers * link aws-c-common in test package * add AWS_CAL_USE_IMPORT_EXPORT interface definition if shared * modernize a little bit more * more elegant way to define target for legacy generators * add transitive_libs to aws-c-common * use version range for openssl