Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-c-cal: modernize more for conan v2 + bump openssl #17100

Merged
merged 10 commits into from
Jun 1, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 18, 2023

  • conan v2:
    • fix windows/shared (protect double deletion of fPIC)
    • fix test package (logic based on self.user_info can't work for conan v2, and it was anyway wrong to define this user_info for the sole purpose of test package)
  • bump openssl to 3.x

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 18, 2023

[100%] Linking C executable test_package
/opt/conan/binutils/bin/ld: CMakeFiles/test_package.dir/test_package.c.o: undefined reference to symbol 'aws_logger_init_standard'
/opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/BuildSingleReference/p/aws-ccfae5d5a8245f/p/lib/libaws-c-common.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

I explicitly link AWS::aws-c-common in test package, how can it happen?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
13 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 19, 2023

v2 pipeline, all shared:

[100%] Linking C executable test_package
/opt/conan/binutils/bin/ld: CMakeFiles/test_package.dir/test_package.c.o: undefined reference to symbol 'aws_logger_init_standard'
/opt/conan/binutils/bin/ld: /home/conan/w/prod-v2/BuildSingleReference/p/aws-ccfae5d5a8245f/p/lib/libaws-c-common.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

I link AWS::aws-c-common in test package (aws_logger_init_standard is a function of aws-c-common: https://github.com/awslabs/aws-c-common/blob/v0.8.2/include/aws/common/logging.h#L306-L310), so why does it fail? conan-io/conan#13723?

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Apr 20, 2023
@SpaceIm SpaceIm reopened this Apr 20, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this May 5, 2023
@SpaceIm SpaceIm reopened this May 6, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (af0a9f24c78406f97ef6adbc2a799a4a938a4874):

  • aws-c-cal/0.5.12@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.20@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.19@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.17@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.13@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.11@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 12 (af0a9f24c78406f97ef6adbc2a799a4a938a4874):

  • aws-c-cal/0.5.19@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.12@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.20@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.13@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.11@:
    All packages built successfully! (All logs)

  • aws-c-cal/0.5.17@:
    All packages built successfully! (All logs)

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented May 31, 2023

@uilianries @jcar87 @RubenRBS @danimtb Could you review please? This PR is mandatory for other aws recipe PRs opened for more than 1 month, and ultimately for PR providing v2 support to aws-sdk-cpp (and also fix #17382).

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 5240ae1 into conan-io:master Jun 1, 2023
@SpaceIm SpaceIm deleted the aws-c-cal-bump-openssl branch June 1, 2023 17:20
samuel-emrys pushed a commit to samuel-emrys/conan-center-index that referenced this pull request Jun 3, 2023
* bump openssl

* modernize more for conan v2

* restore test of libcrypto

* aws-c-common public headers are included by aws-c-cal public headers

* link aws-c-common in test package

* add AWS_CAL_USE_IMPORT_EXPORT interface definition if shared

* modernize a little bit more

* more elegant way to define target for legacy generators

* add transitive_libs to aws-c-common

* use version range for openssl
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
* bump openssl

* modernize more for conan v2

* restore test of libcrypto

* aws-c-common public headers are included by aws-c-cal public headers

* link aws-c-common in test package

* add AWS_CAL_USE_IMPORT_EXPORT interface definition if shared

* modernize a little bit more

* more elegant way to define target for legacy generators

* add transitive_libs to aws-c-common

* use version range for openssl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants