-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-c-io: fix interface definition for shared lib on windows + bump s2n + add package_type #17104
aws-c-io: fix interface definition for shared lib on windows + bump s2n + add package_type #17104
Conversation
This definition is mandatory to properly define __delcspec(dllimport) if shared on windows It's very important since aws-c-io has at least one global symbol in its interface.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 5 (
|
@uilianries @jwillikers @ericLemanissier @jcar87 @prince-chrismc could you review please? There are several other aws PRs to merge before aws-sdk-cpp PR can pass v2 pipeline, and this one is the current bottleneck of other aws PRs (then #17107 & #17110 will be the next bottlenecks, then #17108 & #17111, then #17117, then #17120, and finally we could build #17125 which has been opened 2 months ago 😐 ). |
… windows + bump s2n + add package_type * add AWS_IO_USE_IMPORT_EXPORT interface definition This definition is mandatory to properly define __delcspec(dllimport) if shared on windows It's very important since aws-c-io has at least one global symbol in its interface. * add package_type * bump s2n * modernize a little bit more * more elegant way to define target for legacy generators * aws-c-common is a public dependency of aws-c-io
aws-c-http
shared againstaws-c-io
shared with Visual Studio. It was failing withh1_connection.c.obj : error LNK2019: unresolved external symbol g_aws_channel_max_fragment_size referenced in function s_connection_new
(g_aws_channel_max_fragment_size
is a global symbol defined inaws-c-io
, so it MUST have__declspec(dllimport)
at consume time).