Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-c-io: fix interface definition for shared lib on windows + bump s2n + add package_type #17104

Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 18, 2023

  • add AWS_IO_USE_IMPORT_EXPORT interface definition. This definition is mandatory to properly define __delcspec(dllimport) if shared on windows.It's very important since aws-c-io has at least one global symbol in its interface. I've seen this issue while trying to build aws-c-http shared against aws-c-io shared with Visual Studio. It was failing with h1_connection.c.obj : error LNK2019: unresolved external symbol g_aws_channel_max_fragment_size referenced in function s_connection_new (g_aws_channel_max_fragment_size is a global symbol defined in aws-c-io, so it MUST have __declspec(dllimport) at consume time).
  • add package_type
  • bump s2n

SpaceIm added 3 commits April 18, 2023 21:57
This definition is mandatory to properly define __delcspec(dllimport) if shared on windows
It's very important since aws-c-io has at least one global symbol in its interface.
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
13 tasks
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 20, 2023

waiting for #17100, #17105 & #17122

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@SpaceIm SpaceIm closed this Jun 1, 2023
@SpaceIm SpaceIm reopened this Jun 1, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (2825759ef029036898087cd33baecd7e0c98452e):

  • aws-c-io/0.13.4@:
    All packages built successfully! (All logs)

  • aws-c-io/0.11.2@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.20@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.9@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.5@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.13@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 5 (2825759ef029036898087cd33baecd7e0c98452e):

  • aws-c-io/0.13.4@:
    All packages built successfully! (All logs)

  • aws-c-io/0.11.2@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.13@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.20@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.9@:
    All packages built successfully! (All logs)

  • aws-c-io/0.10.5@:
    All packages built successfully! (All logs)

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jun 8, 2023

@uilianries @jwillikers @ericLemanissier @jcar87 @prince-chrismc could you review please? There are several other aws PRs to merge before aws-sdk-cpp PR can pass v2 pipeline, and this one is the current bottleneck of other aws PRs (then #17107 & #17110 will be the next bottlenecks, then #17108 & #17111, then #17117, then #17120, and finally we could build #17125 which has been opened 2 months ago 😐 ).

@conan-center-bot conan-center-bot merged commit f913b53 into conan-io:master Jun 8, 2023
@SpaceIm SpaceIm deleted the fix/aws-c-io-fix-dllimport branch June 8, 2023 15:25
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
… windows + bump s2n + add package_type

* add AWS_IO_USE_IMPORT_EXPORT interface definition

This definition is mandatory to properly define __delcspec(dllimport) if shared on windows
It's very important since aws-c-io has at least one global symbol in its interface.

* add package_type

* bump s2n

* modernize a little bit more

* more elegant way to define target for legacy generators

* aws-c-common is a public dependency of aws-c-io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Can't build aws-c-io
7 participants