Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2n: remove component workaround for legacy generators #17122

Merged
merged 3 commits into from
Apr 28, 2023
Merged

s2n: remove component workaround for legacy generators #17122

merged 3 commits into from
Apr 28, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 19, 2023

Remove component workaround to avoid to define a AWS::AWS target in legacy generators. Rely on custom cmake module instead.

@SpaceIm SpaceIm changed the title s2: remove component workaround for legacy generators s2n: remove component workaround for legacy generators Apr 19, 2023
@prince-chrismc prince-chrismc mentioned this pull request Apr 19, 2023
Open
@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
Merged
13 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
jwillikers
jwillikers previously approved these changes Apr 19, 2023
View reviewed changes
@SpaceIm SpaceIm mentioned this pull request Apr 20, 2023
Merged
3 tasks
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (64c30afa9fd3bb6c9fc4264d85b4e0be15eb4b9b):

  • s2n/1.3.9@:
    All packages built successfully! (All logs)

  • s2n/1.3.31@:
    All packages built successfully! (All logs)

  • s2n/1.3.15@:
    All packages built successfully! (All logs)

  • s2n/1.2.0@:
    All packages built successfully! (All logs)

  • s2n/1.0.11@:
    All packages built successfully! (All logs)

  • s2n/1.1.1@:
    All packages built successfully! (All logs)

  • s2n/1.1.0@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 3 (64c30afa9fd3bb6c9fc4264d85b4e0be15eb4b9b):

  • s2n/1.2.0@:
    All packages built successfully! (All logs)

  • s2n/1.3.9@:
    All packages built successfully! (All logs)

  • s2n/1.3.15@:
    All packages built successfully! (All logs)

  • s2n/1.1.1@:
    All packages built successfully! (All logs)

  • s2n/1.3.31@:
    All packages built successfully! (All logs)

  • s2n/1.1.0@:
    All packages built successfully! (All logs)

  • s2n/1.0.11@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 1eefbb3 into conan-io:master Apr 28, 2023
@SpaceIm SpaceIm deleted the s2n-remove-component branch April 28, 2023 05:16
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
@SpaceIm @pezy
(conan-io#17122) s2n: remove component workaround for legacy generators
fb651ab 
* more elegant way to define target for legacy generators

* use version range for openssl

* openssl >= 1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @prince-chrismc @jwillikers