Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-c-sdkutils: add missing interface definition if shared + modernize more for conan v2 #17118

Merged
merged 4 commits into from
May 11, 2023
Merged

aws-c-sdkutils: add missing interface definition if shared + modernize more for conan v2 #17118

merged 4 commits into from
May 11, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 19, 2023

see https://github.com/awslabs/aws-c-sdkutils/blob/v0.1.9/include/aws/sdkutils/exports.h

@prince-chrismc prince-chrismc mentioned this pull request Apr 19, 2023
Open
@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
Merged
13 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request Apr 20, 2023
Merged
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@SpaceIm SpaceIm mentioned this pull request May 5, 2023
Closed
@SpaceIm SpaceIm closed this May 5, 2023
@SpaceIm SpaceIm reopened this May 5, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (a0b140fc298c527f375abd2972ec75513abc7c28):

  • aws-c-sdkutils/0.1.1@:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.3@:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.2@:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 4 (a0b140fc298c527f375abd2972ec75513abc7c28):

  • aws-c-sdkutils/0.1.3@:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.2@:
    All packages built successfully! (All logs)

  • aws-c-sdkutils/0.1.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot requested a review from danimtb May 11, 2023 12:00
@conan-center-bot conan-center-bot merged commit e8866f7 into conan-io:master May 11, 2023
@SpaceIm SpaceIm deleted the aws-c-sdkutils-dllimport branch May 11, 2023 16:16
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
@SpaceIm @pezy
(conan-io#17118) aws-c-sdkutils: add missing interface definition if …
8fde799 
…shared + modernize more for conan v2

* add AWS_SDKUTILS_USE_IMPORT_EXPORT interface definition if shared

* modernize more

* more elegant way to define target for legacy generators

* aws-c-common is a public dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @AbrilRBS @danimtb