test(color-picker): alpha support #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Renamed `color` properties and updated values. - Renamed the property `color`, use `kind` instead. - Updated the accepted values of `kind` to `brand`, `danger`, `info`, `success`, and `warning`.
#6060) BREAKING CHANGE: Removed events. - Removed the event `calciteDatePickerSelect` on `CalciteDatePickerMonthHeader` - Removed the event `calciteDatePickerSelect` on `CalciteDatePickerMonth` - Removed the event `calciteDatePickerActiveDateChange` on `CalciteDatePickerMonth`
**Related Issue:** #5798 BREAKING CHANGE: Removed deprecated event payload. - Removed the `event.detail` property on the event `calciteChipDismiss`, use `event.target` instead. - Removed the `event.detail` property on the event `calciteComboboxChipDismiss`, use `event.target` instead.
…ved deprecated `intl*` & accessible label properties (#6050) BREAKING CHANGE: Removed deprecated intl* & accessible label properties. - modal: * Removed the property `intlClose` , use `messsageOverrides.close` instead. - notice: * Removed the property `intlClose` , use `messsageOverrides.close` instead. - pagination: * Removed the property `textLabelNext` , use `messsageOverrides.next` instead. * Removed the property `textLabelPrevious` , use `messsageOverrides.previous` instead. - panel: * Removed the property `intlClose` , use `messsageOverrides.close` instead. * Removed the property `intlOptions`, use `messsageOverrides.options` instead. - pick-list-item: * Removed the property `intlRemove` , use `messsageOverrides.remove` instead. - popover: * Removed the property `intlClose` , use `messsageOverrides.close` instead.
**Related Issue:** #5798 BREAKING CHANGE: Removed deprecated properties. Removed the property `active`, use `open` instead. Removed the property `dimissible`, use `closable` property instead.
BREAKING CHANGE: Removed the `focusId` parameter from `action-bar` and `action-pad`'s `setFocus` method - **action-bar, action-pad:** Removed `focusId` paramter `setFocus` method, focus is delegated to the first focusable element.
…6062) BREAKING CHANGE: Removed deprecated properties and values. - `button`: Removed the property `form`, this property is no longer needed if the component is placed inside a form. - `button`, `fab`, `split-button`: Renamed the property `color`, use `kind` instead. - `button`, `fab`, `split-button`: Updated the accepted values of `kind` to `brand` (default), `danger`, `inverse`, and `neutral`. - `button`, `split-button`: Updated the accepted values of `appearance` to `outline`, `outline-fill` and `solid` (default). - `fab`: Updated the accepted values of `appearance` to `outline-fill` and `solid` (default).
BREAKING CHANGE: Renamed `color` property and updated values, and updated `appearance` values. - Renamed the property `color`, use `kind` instead. - Updated the accepted values of `kind` to `brand`, `inverse`, and `neutral` (default). - Updated the accepted values of `appearance` to , `outline`, `outline-fill` and `solid` (default).
docs(switch): Remove deprecated event detail doc
**Related Issue:** #5929 ## Summary This one was already done 😄, this just cleans up a couple of outdated "clear" references.
Removes individually specified `Appearance` interfaces and instead uses `Extract<>` to source values from a single defined reference.
This PR was automatically generated by the update-doc GitHub action Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
Cleans up some stragglers from the recent `kind` property work. Also removes the `Color` section from the `Styling` conventions. There are still some instances of `color` in generated Readme files but they should be fixed next time those are auto-generated.
**Related Issue:** #5312 ## Summary Resolves bugs keyboard interaction and focus-in/focus-out Cleans up component events, state, methods, and props Refactors the component to make the value prop the source of truth and driver of the component state Refactor tests to remove duplicates and improve scan-ability. ### Before https://user-images.githubusercontent.com/4733155/189963194-da8ee607-f4a8-46bf-8e21-9b36d2aeef64.mov ### After https://user-images.githubusercontent.com/3362490/208055841-20e6630a-c2ab-43b6-815d-18f14b0cd911.mp4
…end, endAsDate properties (#6076) BREAKING CHANGE: Removed the `start`, `end`, `startAsDate`, and `endAsDate` properties. - Removed the property `start`, use `value` instead. - Removed the property `end`, use `value` instead. - Removed the property `startAsDate`, use `valueAsDate` instead. - Removed the property `endAsDate`, use `valueAsDate` instead.
**Related Issue:** Proposed as part of Shell / Layout enhancements: https://confluencewikidev.esri.com/pages/viewpage.action?pageId=222267264 (VPN needed) ## Summary This is a draft PR to add two new slots to `calcite-shell`: `modal` and `alerts`. This pattern was proposed as part of our upcoming Shell / layout improvements, and would be leveraged by the upcoming proposed `calcite-sheet` component. When expected components are slotted into named slots, conditional styles are applied to constrain their extent to that of the `calcite-shell` (including covering the existing `header` and `footer` slots). This is useful in many cases, specifically when the `calcite-shell` is embedded amongst other content, like tutorials, documentation pages, or any place the user experience is not a completely full-screen `calcite-shell`. When these components are _not_ slotted into the new `calcite-shell` slots - their behavior remains unchanged. A demo is available locally at `/demos/shell/basic-slotted-elements.html` cc @asangma @mitc7862 Screen recording of proposed behavior: https://user-images.githubusercontent.com/4733155/207209472-000f38d5-d44c-4ead-a277-dd3fc5ef905c.mov
BREAKING CHANGE: removed `intl` properties. - Removed, `intlHex` property, aria-label of color-picker-hex-input is set to `hex` by default. - Removed ,`intlNoColor` property. _note: color-picker-hex-input is `internal` component._
BREAKING CHANGE: Removed `--calcite-modal-padding` CSS variable. - Removed the `--calcite-modal-padding` CSS variable, use the `--calcite-modal-content-padding` CSS variable instead.
…-picker, input-time-picker): bumping the scale of icon to M when parent is scale L (#6267) **Related Issue:** #5698 ## Summary Bumping the scales of `iconStart` and `iconEnd` to M when the parent `tab-title`,`input`, `input-number`, `input-text`, `input-date-picker`, `input-time-picker` components are `scale="l"` for a visual distinction between larger and smaller components without affecting the height of the components when icon(s) are added or removed. Added `_testOnly` snapshots.
I kept running into weird timeout errors in the tests which I suspect were caused by the layered nested functions in the multi-layered "describes" these were resolved when I made each test stand alone. |
…wn is scale L (#6254) **Related Issue:** #5698 ## Summary Bumping the scale of the icon to M when the parent `dropdown-item` is `scale="l"` for a visual distinction between larger and smaller components without affecting the height of the `dropdown-item` when icon(s) are added or removed. Added a `_testOnly` snapshot.
…mp/749-color-picker-alpha-support # Conflicts: # src/components/color-picker/color-picker.e2e.ts # src/components/color-picker/color-picker.tsx # src/components/color-picker/usage/Minimal.md
This PR was automatically generated by the update-browserslist-db GitHub action Co-authored-by: jcfranco <jcfranco@users.noreply.github.com> Co-authored-by: Ben Elan <belan@esri.com>
**Related Issue:** N/A ## Summary Updates the changelog organization (alphabetical order) and updates the indentation throughout. 🧹
This PR was automatically generated by the update-doc GitHub action Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.47.1 to 5.48.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v5.48.2</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.48.1...v5.48.2">5.48.2</a> (2023-01-16)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p> <h2>v5.48.1</h2> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.48.0...v5.48.1">5.48.1</a> (2023-01-09)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/typescript-eslint</code></p> <h2>v5.48.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.47.1...v5.48.0">5.48.0</a> (2023-01-02)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>website:</strong> fix typo (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/6285">#6285</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/3f8d105e9ee500428774b498083c4bc02bfd81b8">3f8d105</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>eslint-plugin:</strong> specify which method is unbound and added test case (<a href="https://github-redirect.dependabot.com/typescript-eslint/typescript-eslint/issues/6281">#6281</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/cf3ffdd49aceb734ce18dc44ed6a11f7701f178e">cf3ffdd</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.48.1...v5.48.2">5.48.2</a> (2023-01-16)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/parser</code></p> <h2><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.48.0...v5.48.1">5.48.1</a> (2023-01-09)</h2> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/parser</code></p> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v5.47.1...v5.48.0">5.48.0</a> (2023-01-02)</h1> <p><strong>Note:</strong> Version bump only for package <code>@typescript-eslint/parser</code></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/46a7c73152506d7f50c94bd9849a0353014f5ad8"><code>46a7c73</code></a> chore: publish v5.48.2</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/10ce912b4fd4b2928e7df1e7ff9e74434f4c52d3"><code>10ce912</code></a> chore: publish v5.48.1</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/4ab9bd7f7c1812df4371d1fd3202969c1039e8a7"><code>4ab9bd7</code></a> chore: publish v5.48.0</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v5.48.2/packages/parser">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <belan@esri.com>
…calcite-components into astump/749-color-picker-alpha-support # Conflicts: # src/components/color-picker/color-picker.e2e.ts # src/components/color-picker/color-picker.tsx
…ri/calcite-components into astump/749-color-picker-alpha-support
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #749
Summary
Cleans up tests for alpha feature on color picker. There is something wrong with Puppeteer causing an unknown error when puppeteer attempts to make programmatic changes to the alpha input box but these changes have been tested manually and are good to go for the 1.0 release. A ticket has been made to address the unstable tests.