Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(notice)!: remove deprecated properties #6004

Merged
merged 25 commits into from
Dec 15, 2022
Merged

refactor(notice)!: remove deprecated properties #6004

merged 25 commits into from
Dec 15, 2022

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #5798

BREAKING CHANGE: Removed deprecated properties.

Removed the property active, use open instead.
Removed the property dimissible, use closable property instead.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 13, 2022
@anveshmekala anveshmekala added breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 13, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 13, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 13, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 13, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 13, 2022 23:57
@anveshmekala anveshmekala requested a review from a team as a code owner December 13, 2022 23:57
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 13, 2022
@anveshmekala anveshmekala removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 14, 2022
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 14, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 14, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022
driskull
driskull approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022
@anveshmekala anveshmekala merged commit 6b53776 into master Dec 15, 2022
@anveshmekala anveshmekala deleted the anveshmekala/5798-notice-deprecations branch December 15, 2022 21:03
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @driskull