Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(radio-group)!: remove event.detail payload from events #6048

Merged
merged 2 commits into from
Dec 15, 2022
Merged

refactor(radio-group)!: remove event.detail payload from events #6048

merged 2 commits into from
Dec 15, 2022

Conversation

driskull
Copy link
Member

BREAKING CHANGE: Removed event.detail payload from events.

  • Removed the event.detail property on the event calciteRadioGroupChange, use event.target instead.

@driskull driskull changed the title refactor(radio-group)!: remove event.detail payload from events. #6007 refactor(radio-group)!: remove event.detail payload from events Dec 15, 2022
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 15, 2022
@driskull driskull marked this pull request as ready for review December 15, 2022 01:09
@driskull driskull requested a review from a team as a code owner December 15, 2022 01:09
@driskull
Copy link
Member Author

@anveshmekala @eriklharper @benelan can one of you review?

benelan
benelan approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull merged commit 58a2246 into master Dec 15, 2022
@driskull driskull deleted the dris0000/radio-group-event-detail branch December 15, 2022 20:44
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@driskull driskull

Labels
refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @benelan