refactor(button, fab, split-button)!: Update properties and values #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
@macandcheese code changes look good. Can we update the PR body to make the changes a little more clear?
Removed the button property form, this property is no longer needed if the component is placed inside a form.
At first glance, I wasn't sure if there was a property "button"? :)
|
Maybe something like
|
BREAKING CHANGE: Removed deprecated properties and values. - `button`: Removed the property `form`, this property is no longer needed if the component is placed inside a form. - `button`, `fab`, `split-button`: Renamed the property `color`, use `kind` instead. - `button`, `fab`, `split-button`: Updated the accepted values of `kind` to `brand` (default), `danger`, `inverse`, and `neutral`. - `button`, `split-button`: Updated the accepted values of `appearance` to `outline`, `outline-fill` and `solid` (default). - `fab`: Updated the accepted values of `appearance` to `outline-fill` and `solid` (default).
9be0095 to
bcddc09
Compare
|
@driskull want to give that new verbiage a look? @SkyeSeitz @ashetland a couple of Chromatic changes to approve - reflecting to the change of default value for FAB |
|
Verbiage looks good! 👀 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Removed deprecated properties and values.
button: Removed the propertyform, this property is no longer needed if the component is placed inside a form.button,fab,split-button: Renamed the propertycolor, usekindinstead.button,fab,split-button: Updated the accepted values ofkindtobrand(default),danger,inverse, andneutral.button,split-button: Updated the accepted values ofappearancetooutline,outline-fillandsolid(default).fab: Updated the accepted values ofappearancetooutline-fillandsolid(default).