Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(modal,notice,pagination,panel,pick-list-item,popover)!: removed deprecated intl* & accessible label properties #6050

Merged
merged 11 commits into from
Dec 15, 2022
Merged

refactor(modal,notice,pagination,panel,pick-list-item,popover)!: removed deprecated intl* & accessible label properties #6050

merged 11 commits into from
Dec 15, 2022

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Dec 15, 2022 •
edited
Loading

BREAKING CHANGE: Removed deprecated intl* & accessible label properties.

  • modal:

    • Removed the property intlClose , use messsageOverrides.close instead.

  • notice:

    • Removed the property intlClose , use messsageOverrides.close instead.

  • pagination:

    • Removed the property textLabelNext , use messsageOverrides.next instead.
    • Removed the property textLabelPrevious , use messsageOverrides.previous instead.

  • panel:

    • Removed the property intlClose , use messsageOverrides.close instead.
    • Removed the property intlOptions, use messsageOverrides.options instead.

  • pick-list-item:

    • Removed the property intlRemove , use messsageOverrides.remove instead.

  • popover:

    • Removed the property intlClose , use messsageOverrides.close instead.

@anveshmekala
refactor(modal,notice,pagination,panel,pick-list-item,popover): remov…
630c49a 
…e deprecated intl & accessible label properties
@anveshmekala anveshmekala added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Dec 15, 2022
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 15, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 15, 2022 02:13
@anveshmekala anveshmekala requested a review from a team as a code owner December 15, 2022 02:13
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 15, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022
driskull
driskull approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022
@anveshmekala anveshmekala merged commit 37637ca into master Dec 15, 2022
@anveshmekala anveshmekala deleted the anveshmekala/5946-remove-intl-deprecations-MtoP branch December 15, 2022 21:00
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @driskull