Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chip,combobox-item)!: remove deprecated event payload. #6028

Merged
merged 8 commits into from
Dec 15, 2022
Merged

refactor(chip,combobox-item)!: remove deprecated event payload. #6028

merged 8 commits into from
Dec 15, 2022

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Dec 14, 2022 •
edited
Loading

BREAKING CHANGE: Removed deprecated event payload.

  • Removed the event.detail property on the event calciteChipDismiss, use event.target instead.
  • Removed the event.detail property on the event calciteComboboxChipDismiss, use event.target instead.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 14, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 14, 2022 17:01
@anveshmekala anveshmekala requested a review from a team as a code owner December 14, 2022 17:01
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 15, 2022
@anveshmekala anveshmekala merged commit 65ba931 into master Dec 15, 2022
@anveshmekala anveshmekala deleted the anveshmekala/5798-remove-deprecated-event-paylod branch December 15, 2022 20:59
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @driskull