Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calcite-color] add support for alpha #749

Closed
jcfranco opened this issue Jul 22, 2020 · 29 comments
Closed

[calcite-color] add support for alpha #749

jcfranco opened this issue Jul 22, 2020 · 29 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2023 May Priorities

Comments

@jcfranco
Copy link
Member

jcfranco commented Jul 22, 2020 •
edited
Loading

The color picker needs to support alpha channel updates. #64 (comment) has some designs with opacity.

Not sure if the design needs any tweaks, but it'd be nice for the final design to have an alpha channel input as well. The color picker from Chrome dev tool's has something similar:

cdt-cp-colors
@jcfranco jcfranco added the enhancement Issues tied to a new feature or request. label Jul 22, 2020
@jcfranco jcfranco added this to the 🔨 v1-beta.34 milestone Jul 22, 2020
@bstifle
Copy link

bstifle commented Jul 22, 2020

👀

@jcfranco jcfranco mentioned this issue Jul 23, 2020
Merged
5 tasks
@jcfranco jcfranco changed the title [color-picker] add support for alpha [calcite-color] add support for alpha Jul 23, 2020
@macandcheese macandcheese removed this from the 📦 v1-beta.34 milestone Jul 29, 2020
@jcfranco
Copy link
Member Author

Another thing to consider in the design is the selected color + transparency preview. One idea would be to update calcite-color-swatch to support transparency (rough mockup 😄):

Screen Shot 2020-07-29 at 1 31 12 PM

@bstifle
Copy link

bstifle commented Jul 29, 2020

yeah i dig it

@macandcheese
Copy link
Contributor

Yeah looks good... Think that's a pretty universal treatment for opacity so should be familiar.

@bstifle
Copy link

bstifle commented Jul 29, 2020 •
edited
Loading

image
here's a comp with the transparency checker fill.

light theme using 4x4 #000000 squares at 40% opacity
dark theme using 4x4 #FFFFFF squares at 40% opacity

@bstifle
Copy link

bstifle commented Jul 29, 2020

image
ok this is better.

#CACACA for light theme
#6A6A6A for dark

@jcfranco jcfranco modified the milestones: v1.0.0-beta.46, v1.0.0-beta.45 Nov 10, 2020
@smambrose
Copy link

Is there any progress on this one? Testers for charts keep running into it and noticing they can't control this.

@jcfranco
Copy link
Member Author

jcfranco commented Mar 5, 2021

@smambrose Not for the time being. I'll move this to backlog until it's ready for development. I estimate this will land after 1.0.0 ships (after April).

@ashetland ashetland mentioned this issue Feb 28, 2023
Closed
alisonailea added a commit that referenced this issue Mar 16, 2023
@alisonailea @macandcheese
@driskull @anveshmekala @github-actions @benelan @calcite-admin @jcfranco @eriklharper @geospatialem @dependabot @mpriour @jona7150 @annierm18 @Elijbet
test(color-picker): alpha support (#6265)
50103dd 
**Related Issue:** #749

## Summary

Cleans up tests for alpha feature on color picker. There is something
wrong with Puppeteer causing an unknown error when puppeteer attempts to
make programmatic changes to the alpha input box but these changes have
been tested manually and are good to go for the 1.0 release. A ticket
has been made to address the unstable tests.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Adam Tirella <macandcheese@users.noreply.github.com>
Co-authored-by: Matt Driscoll <mdriscoll@esri.com>
Co-authored-by: Anveshreddy mekala <anv11827@esri.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ben Elan <belan@esri.com>
Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Co-authored-by: jcfranco <jcfranco@users.noreply.github.com>
Co-authored-by: Erik Harper <eharperdicianno@esri.com>
Co-authored-by: Kitty Hurley <khurley@esri.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Priour <mpriour@esri.com>
Co-authored-by: jona7150 <jturpin@esri.com>
Co-authored-by: Aine Fitzgerald Coleman <anniermfc@gmail.com>
Co-authored-by: Eliza Khachatryan <eli97736@esri.com>
@brittneytewks brittneytewks added the estimate - 5 A few days of work, definitely requires updates to tests. label Mar 21, 2023
@jcfranco
Copy link
Member Author

Update: this will land this week, but will be available via next and not in the April release. Automated tests will be updated/added separately.

@jcfranco jcfranco mentioned this issue Apr 24, 2023
Open
jcfranco added a commit that referenced this issue May 3, 2023
@jcfranco
feat(color-picker): add support for alpha channel (deprecates `hideCh…
83c5808 
…annels`, `hideHex`, `hideSaved`) (#2841)

**Related Issue:** #749 

## Summary

This brings opacity support to the color picker along with some design
updates.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and unassigned jcfranco May 3, 2023
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 3, 2023
@geospatialem
Copy link
Member

Verified in 1.4.0-next.6 with the alpha-channel attribute:

<calcite-color-picker alpha-channel></calcite-color-picker>

image

@geospatialem geospatialem added the future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. label May 4, 2023
@geospatialem
Copy link
Member

Adding to the new future breaking change label, where a few deprecated props take place:

  • hideChannels
  • hideHex
  • hideSaved

@jcfranco jcfranco mentioned this issue May 5, 2023
Closed
@ashetland ashetland mentioned this issue Jun 12, 2023
Open
4 tasks
@geospatialem geospatialem mentioned this issue May 24, 2024
Closed
12 tasks
@geospatialem geospatialem mentioned this issue Jun 28, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. future breaking change Issues and pull requests with deprecation(s), requires a breaking change in a future milestone. p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2023 May Priorities
Development

No branches or pull requests