fix(tab, tabs, tab-title, input, input-number, input-text, input-date-picker, input-time-picker): bumping the scale of icon to M when parent is scale L #6267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
reviewed
Jan 11, 2023
…der, and icon without
…enders-icon-scale-M
benelan
approved these changes
Jan 13, 2023
| const iconStart = await page.find("calcite-tab-title >>> .calcite-tab-title--icon.icon-start"); | ||
| const iconEnd = await page.find("calcite-tab-title >>> .calcite-tab-title--icon.icon-end"); | ||
| const iconStart = await page.find(iconStartHtml); | ||
| const iconEnd = await page.find(iconEndHtml); |
There was a problem hiding this comment.
Yep, been working with design on this. I'll run it through them again to make sure.
…out icon presence
…enders-icon-scale-M
eriklharper
approved these changes
Jan 14, 2023
benelan
added a commit
that referenced
this pull request
Jan 14, 2023
* master: fix(tab, tabs, tab-title, input, input-number, input-text, input-date-picker, input-time-picker): bumping the scale of icon to M when parent is scale L (#6267) 1.0.0-next.725 feat(modal)!: Updates accepted `width` values, adds css variables for width and height (#6166) docs: update component READMEs (#6274) 1.0.0-next.724 feat(date-picker): Update border color (#6273) 1.0.0-next.723 refactor(color-picker)!: remove appearance property (#6276) 1.0.0-next.722 refactor(input-time-picker)!: remove string payload from event. (#6275) 1.0.0-next.721 fix(accordion-item): bumping the scale of icon to M when parent accordion is scale L (#6252)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5698
Summary
Bumping the scales of
iconStartandiconEndto M when the parenttab-title,input,input-number,input-text,input-date-picker,input-time-pickercomponents arescale="l"for a visual distinction between larger and smaller components without affecting the height of the components when icon(s) are added or removed. Added_testOnlysnapshots.