Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(color-picker)!: remove appearance property #6276

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Jan 12, 2023

BREAKING CHANGE: removed appearance property

  • Removed appearance property, use --calcite-ui-border-1: transparent to remove the border instead of the "minimal" value

@benelan benelan requested a review from a team as a code owner January 12, 2023 03:35
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼️

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jan 12, 2023
@geospatialem geospatialem added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 12, 2023
@geospatialem geospatialem merged commit 90be19c into master Jan 12, 2023
@geospatialem geospatialem deleted the benelan/6035-color-picker-appearance branch January 12, 2023 19:15
@github-actions github-actions bot added this to the 2023 January Priorities milestone Jan 12, 2023
benelan added a commit that referenced this pull request Jan 14, 2023
* master:
  fix(tab, tabs, tab-title, input, input-number, input-text, input-date-picker, input-time-picker): bumping the scale of icon to M when parent is scale L (#6267)
  1.0.0-next.725
  feat(modal)!: Updates accepted `width` values, adds css variables for width and height (#6166)
  docs: update component READMEs (#6274)
  1.0.0-next.724
  feat(date-picker): Update border color (#6273)
  1.0.0-next.723
  refactor(color-picker)!: remove appearance property (#6276)
  1.0.0-next.722
  refactor(input-time-picker)!: remove string payload from event. (#6275)
  1.0.0-next.721
  fix(accordion-item): bumping the scale of icon to M when parent accordion is scale L (#6252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants