Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: the end date in date picker range is a square #5544

Closed
benelan opened this issue Oct 22, 2022 · 3 comments
Closed

Bug: the end date in date picker range is a square #5544

benelan opened this issue Oct 22, 2022 · 3 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Milestone
2023 January Prio...

Comments

@benelan
Copy link
Member

benelan commented Oct 22, 2022

Actual Behavior

The end date in date-picker range is a square

image

Expected Behavior

The end date to match the nice, smooth start date #dontbeasquare

Reproduction Sample

https://codepen.io/benesri/pen/NWMQzyQ

Reproduction Steps

  1. Open the sample
  2. Look at the shapes

Reproduction Version

beta.94 through next

Relevant Info

No response

Regression?

beta.93

Esri team

Calcite (dev)
@benelan benelan added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. labels Oct 22, 2022
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Oct 22, 2022
@geospatialem
Copy link
Member

Observed on hover, or focus the end date returns to a filled circle.

date-picker-range-hover

@alisonailea alisonailea added p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. labels Nov 1, 2022
@Elijbet Elijbet added the estimate - 2 Small fix or update, may require updates to tests. label Dec 2, 2022
@Elijbet Elijbet self-assigned this Dec 2, 2022
This was referenced Dec 31, 2022
Closed
Merged
Elijbet added a commit that referenced this issue Jan 20, 2023
@Elijbet
fix(date-picker): end-range is now rounded and has the correct box-sh…
ed30588 
…adow (#6216)

**Related Issue:** #5544

## Summary

Improvements to `date-picker-day` styling include:

- `end-range` is now rounded 
- has the correct `box-shadow`
- styling is consistent for both `dir="ltr"` and `dir="rtl"`
@Elijbet Elijbet added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jan 20, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 20, 2023
@geospatialem
Copy link
Member

Verified in next.729 ✨

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
4 participants
@alisonailea @geospatialem @benelan @Elijbet