Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tip)!: rename dismissed to closed #6297

Merged
merged 1 commit into from
Jan 17, 2023
Merged

refactor(tip)!: rename dismissed to closed #6297

merged 1 commit into from
Jan 17, 2023

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Jan 17, 2023 •
edited
Loading

BREAKING CHANGE : Rename dismissed prop to closed.

@anveshmekala anveshmekala added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Jan 17, 2023
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jan 17, 2023
@anveshmekala anveshmekala marked this pull request as ready for review January 17, 2023 17:46
@anveshmekala anveshmekala requested a review from a team as a code owner January 17, 2023 17:46
@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 17, 2023
@anveshmekala anveshmekala merged commit 0921504 into master Jan 17, 2023
@anveshmekala anveshmekala deleted the anveshmekala/tip-rename-dismissed-to-closed branch January 17, 2023 23:19
@github-actions github-actions bot added this to the 2023 January Priorities milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriklharper eriklharper eriklharper approved these changes

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @eriklharper