Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lfx-mentorship-2022-Sept-Nov] Configurable Interpreter #2371

Closed
8 tasks done
RainbowMango opened this issue Aug 12, 2022 · 11 comments
Closed
8 tasks done

[lfx-mentorship-2022-Sept-Nov] Configurable Interpreter #2371

RainbowMango opened this issue Aug 12, 2022 · 11 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@RainbowMango
Copy link
Member

RainbowMango commented Aug 12, 2022

What would you like to be added:
Now in Resource Interpreter framework, we enabled both built-in and customized interpreter.

We'd like to enable the third interpreter, which is configurable interpreter.

In addition, for the Retain interpreter operation, we have the proposal .

Following documents would help to understand this task:

Why is this needed:

Iteration tasks

@RainbowMango RainbowMango added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 12, 2022
@RainbowMango RainbowMango added this to the v1.4 milestone Aug 12, 2022
@PradyumnaKrishna
Copy link

Hey @RainbowMango I am interested in this project for LFX-Mentorship, will you provide me more information to get started?

@RainbowMango
Copy link
Member Author

I updated a document list to the issue description.

@basit9958
Copy link

basit9958 commented Aug 21, 2022

Hey @RainbowMango, I have read the proposal,documents and the struct and believe we need to build a webhook and write a lua/cue script which contains the logic to retain the configured field by the user to sync changes so the there is no endless loop in karmada control plane. After that we need to register it here cmd/webhook/app/webhook.go .
I am interested in solving this issue , Get me on board for this one.

@jameszhangyukun
Copy link
Contributor

/assign

@chaunceyjiang
Copy link
Member

Friendly ping @jameszhangyukun Any progress?

@RainbowMango
Copy link
Member Author

Hi @chaunceyjiang
@jameszhangyukun made a demo for this.

The next step I think is Resource Interpreter framework cache and reorganize configurations.

@XiShanYongYe-Chang
Copy link
Member

Hi @jameszhangyukun, I'll be involved with you in the development of this work, thanks~

@chaunceyjiang
Copy link
Member

Hi, @jameszhangyukun @RainbowMango @XiShanYongYe-Chang I am also very interested in this, can I participate in the development together?

@XiShanYongYe-Chang
Copy link
Member

Hi, @jameszhangyukun @RainbowMango @XiShanYongYe-Chang I am also very interested in this, can I participate in the development together?

Of course, thank you very much.

@RainbowMango
Copy link
Member Author

Thank you @chaunceyjiang @ikaven1024 @jameszhangyukun @XiShanYongYe-Chang for all your effort in this feature.
It's a big success for all of us!

Most of the planned features have been done and will be delivered with the coming v1.4.0.
For the rest of the improvement task, let's do it in the next release.
/close

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closing this issue.

In response to this:

Thank you @chaunceyjiang @ikaven1024 @jameszhangyukun @XiShanYongYe-Chang for all your effort in this feature.
It's a big success for all of us!

Most of the planned features have been done and will be delivered with the coming v1.4.0.
For the rest of the improvement task, let's do it in the next release.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

7 participants