-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add edit mode for karmadactl interpreter command #2831
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2831 +/- ##
==========================================
- Coverage 37.72% 37.71% -0.02%
==========================================
Files 200 200
Lines 18435 18435
==========================================
- Hits 6955 6952 -3
- Misses 11075 11078 +3
Partials 405 405
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
A question, why user want to edit the script by this command? |
Because it's hard to edit Lua script in yaml. This command helps user edit it in a Lua file. I will demonstrate it in tomorrow's meeting. |
ad86c12
to
c6dff4b
Compare
c6dff4b
to
11ee626
Compare
11ee626
to
b6d1f09
Compare
Thanks a lot~ |
9ada9ee
to
ad7caad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
/lgtm
ad7caad
to
9ba2d79
Compare
Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
9ba2d79
to
f161a2a
Compare
Hi @RainbowMango, can you help rerun the CI, it failed for deleting the kind node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @XiShanYongYe-Chang , your LGTM is removed, plz take a look again. |
OK |
Signed-off-by: yingjinhui yingjinhui@didiglobal.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
add edit mode for karmadactl interpreter command.
Which issue(s) this PR fixes:
part of #2371
Special notes for your reviewer:
Example
Prepare
customization.yml
Will open a default editor:
./karmadactl interpret -f get-replica.yml --edit
Does this PR introduce a user-facing change?: