-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interpret command #2750
add interpret command #2750
Conversation
@RainbowMango: PLZ check the usage of this command. |
Codecov Report
@@ Coverage Diff @@
## master #2750 +/- ##
==========================================
- Coverage 37.91% 37.85% -0.06%
==========================================
Files 189 190 +1
Lines 17644 17696 +52
==========================================
+ Hits 6689 6699 +10
- Misses 10548 10590 +42
Partials 407 407
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3a0076c
to
b32ea52
Compare
b32ea52
to
8452ee5
Compare
@RainbowMango Will you merge this PR when you feel ok? I will do this work in several PRs. |
Hi, @ikaven1024 perhaps you can develop it in this PR as multiple commits. Because the karmadactl will have a big change recently at #2664 |
8452ee5
to
c3bb62b
Compare
039d962
to
1b0b5be
Compare
Waiting for #2794 ready |
f5b5699
to
f129cb6
Compare
f129cb6
to
31af307
Compare
@RainbowMango @XiShanYongYe-Chang It's ready for review. |
84b5152
to
b217f8d
Compare
@XiShanYongYe-Chang I have rebase the master, but still fail: |
b217f8d
to
096c807
Compare
I have pick out the |
096c807
to
e89a0b3
Compare
/assign |
This error is caused by the failure to delete the Kind node and can be ignored. |
4d1053d
to
3de2389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this approach is much better now.
The review is still ongoing.
e0f4baf
to
3208ffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small touches, otherwise LGTM.
79b63d6
to
a5800dd
Compare
Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>
a5800dd
to
81b2596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yingjinhui yingjinhui@didiglobal.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
add skeleton of interpreter command.
Which issue(s) this PR fixes:
part of #2371
Special notes for your reviewer:
Usage
Check
Prepare a
customization.yaml
Output:
Does this PR introduce a user-facing change?: