Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] add test case for resource interpreter customization #2829

Conversation

XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang commented Nov 18, 2022

Signed-off-by: changzhen changzhen5@huawei.com

What type of PR is this?

/kind feature

What this PR does / why we need it:

add test case for resource interpreter customization:

  • InterpretReplica
  • ReviseReplica

Which issue(s) this PR fixes:
part of #2371

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2022
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2022
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-e2e-for-resourceInterpreterCustomization branch from 4309b9d to 01964e0 Compare November 18, 2022 02:16
@XiShanYongYe-Chang
Copy link
Member Author

/cc @RainbowMango @jameszhangyukun

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: jameszhangyukun.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @RainbowMango @jameszhangyukun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #2829 (2819df4) into master (594ad9f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2829      +/-   ##
==========================================
- Coverage   37.91%   37.89%   -0.02%     
==========================================
  Files         189      190       +1     
  Lines       17644    17681      +37     
==========================================
+ Hits         6689     6701      +12     
- Misses      10548    10573      +25     
  Partials      407      407              
Flag Coverage Δ
unittests 37.89% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ceinterpreter/configurableinterpreter/luavm/lua.go 58.04% <0.00%> (ø)
.../resourceinterpreter/defaultinterpreter/default.go 0.00% <0.00%> (ø)
...armadactl/cmdinit/karmada/webhook_configuration.go 81.91% <0.00%> (-6.53%) ⬇️
pkg/karmadactl/util/idempotency.go 6.74% <0.00%> (-1.60%) ⬇️
pkg/karmadactl/cmdinit/utils/rbac.go 0.00% <0.00%> (ø)
pkg/karmadactl/cmdinit/karmada/deploy.go 0.00% <0.00%> (ø)
pkg/util/metrics/metrics.go 71.42% <0.00%> (ø)
pkg/karmadactl/cmdinit/karmada/rbac.go 88.57% <0.00%> (+0.45%) ⬆️
pkg/search/proxy/store/util.go 94.31% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-e2e-for-resourceInterpreterCustomization branch 3 times, most recently from bdcaff3 to 385bd3c Compare November 18, 2022 04:26
Signed-off-by: changzhen <changzhen5@huawei.com>
Signed-off-by: changzhen <changzhen5@huawei.com>
@XiShanYongYe-Chang XiShanYongYe-Chang force-pushed the add-e2e-for-resourceInterpreterCustomization branch from 354f59e to 2819df4 Compare November 19, 2022 10:16
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2022
@RainbowMango RainbowMango added this to the v1.4 milestone Nov 19, 2022
@karmada-bot karmada-bot merged commit 8aa58ec into karmada-io:master Nov 19, 2022
cleverhu pushed a commit to cleverhu/karmada that referenced this pull request Nov 19, 2022
…r-resourceInterpreterCustomization

[E2E] add test case for resource interpreter customization

Signed-off-by: cleverhu <shouping.hu@daocloud.io>
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-e2e-for-resourceInterpreterCustomization branch November 23, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants