Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable resource interpreter API #2639

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind feature
/kind api-change

What this PR does / why we need it:
This PR proposes the configurable interpreter API and takes the retention as a start.

Basically according to this proposal.

Which issue(s) this PR fixes:
Part of #2371
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE(Part feature)

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 13, 2022
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2022
@RainbowMango RainbowMango force-pushed the pr_resourceinterpreter_customization_api branch from ccc7d0f to 4623d8c Compare October 13, 2022 12:27
@codecov-commenter
Copy link

Codecov Report

Merging #2639 (4623d8c) into master (69ad816) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2639   +/-   ##
=======================================
  Coverage   23.54%   23.54%           
=======================================
  Files         184      184           
  Lines       18487    18487           
=======================================
  Hits         4353     4353           
  Misses      13789    13789           
  Partials      345      345           
Flag Coverage Δ
unittests 23.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RainbowMango RainbowMango force-pushed the pr_resourceinterpreter_customization_api branch from a770f12 to 467493d Compare October 18, 2022 06:50
Signed-off-by: RainbowMango <qdurenhongcai@gmail.com>
@RainbowMango RainbowMango force-pushed the pr_resourceinterpreter_customization_api branch from 467493d to bb32de4 Compare October 18, 2022 07:14
@RainbowMango RainbowMango added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 18, 2022
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit eb0c655 into karmada-io:master Oct 18, 2022
@RainbowMango RainbowMango deleted the pr_resourceinterpreter_customization_api branch October 18, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants