support users can define multiple resourceinterpretercustomization #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2848 +/- ##
==========================================
+ Coverage 37.80% 37.86% +0.05%
==========================================
Files 191 193 +2
Lines 17715 17894 +179
==========================================
+ Hits 6698 6775 +77
- Misses 10610 10705 +95
- Partials 407 414 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pkg/resourceinterpreter/configurableinterpreter/configmanager/manager.go
Outdated
Show resolved
Hide resolved
79f6638 to
c6fbc6c
Compare
|
/cc @chaunceyjiang @jameszhangyukun @ikaven1024 @RainbowMango Can you help take a look? |
|
/assign |
|
LGTM |
pkg/resourceinterpreter/configurableinterpreter/configmanager/accessor.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/configurableinterpreter/configmanager/accessor.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/configurableinterpreter/configmanager/accessor.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/configurableinterpreter/configmanager/accessor.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/configurableinterpreter/configmanager/manager_test.go
Outdated
Show resolved
Hide resolved
pkg/resourceinterpreter/configurableinterpreter/configmanager/manager_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: changzhen <changzhen5@huawei.com>
c6fbc6c to
b1977be
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: changzhen changzhen5@huawei.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support users can define multiple
ResourceInterpreterCustomization, for one operation, only one script will take effect.Which issue(s) this PR fixes:
Part of #2371
Special notes for your reviewer:
Does this PR introduce a user-facing change?: