add kube lib for lua #2871

ikaven1024 · 2022-11-26T17:27:28Z

Signed-off-by: yingjinhui yingjinhui@didiglobal.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
When users use customization to implement GetReplicas, it's difficult to accurate the sum of resource quantity. This PR load the kube library to help do this work.

See the demo:

karmada/pkg/resourceinterpreter/configurableinterpreter/luavm/lua_test.go

Lines 65 to 70 in f6a9956

    
           local kube = require("kube") 
        
           function GetReplicas(desiredObj) 
        
           	replica = desiredObj.spec.replicas 
        
           	requires = kube.accuratePodRequirements(desiredObj.spec.template) 
        
           	return replica, requires  
        
           end`,

Which issue(s) this PR fixes:
part of #2371

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

codecov-commenter · 2022-11-26T17:41:55Z

Codecov Report

Merging #2871 (6dd348f) into master (472ccb5) will increase coverage by 0.09%.
The diff coverage is 64.70%.

@@            Coverage Diff             @@
##           master    #2871      +/-   ##
==========================================
+ Coverage   37.80%   37.90%   +0.09%     
==========================================
  Files         200      201       +1     
  Lines       18461    18511      +50     
==========================================
+ Hits         6980     7016      +36     
- Misses      11073    11084      +11     
- Partials      408      411       +3

Flag	Coverage Δ
unittests	`37.90% <64.70%> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...reter/configurableinterpreter/luavm/lua_convert.go	`73.91% <0.00%> (ø)`
...ceinterpreter/configurableinterpreter/luavm/lua.go	`56.97% <50.00%> (-0.12%)`	⬇️
...einterpreter/configurableinterpreter/luavm/kube.go	`67.39% <67.39%> (ø)`
pkg/search/proxy/store/util.go	`94.31% <0.00%> (+1.42%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

RainbowMango · 2022-11-28T08:42:22Z

I like the idea. Sounds like it makes easier for users to write the scripts.

pkg/resourceinterpreter/configurableinterpreter/luavm/lua_test.go

XiShanYongYe-Chang · 2022-12-02T09:58:55Z

/assign

XiShanYongYe-Chang

LGTM

Do we need to update the getReplicas example in the examples at the same time?

ikaven1024 · 2022-12-05T07:35:56Z

Do we need to update the getReplicas example in the examples at the same time?

OK. I will do it.

XiShanYongYe-Chang · 2022-12-05T08:13:17Z

/lgtm
/assign @RainbowMango

RainbowMango

Good job!
Only some nits and questions.

pkg/resourceinterpreter/configurableinterpreter/luavm/kube.go

RainbowMango · 2022-12-08T08:21:55Z

pkg/resourceinterpreter/configurableinterpreter/luavm/kube.go

+	return 1
+}
+
+func checkResourceQuantity(ls *lua.LState, n int) resource.Quantity {


This function isn't about to check, but parse a resource to resource.Quantity.

Rename to ParseResourceQuantity or one more accurate?

This naming follows gopher-lua's function CheckXxx

karmada/vendor/github.com/yuin/gopher-lua/auxlib.go

Lines 13 to 29 in d4e5f04

func (ls *LState) CheckAny(n int) LValue {

if n > ls.GetTop() {

ls.ArgError(n, "value expected")

}

return ls.Get(n)

}

func (ls *LState) CheckInt(n int) int {

v := ls.Get(n)

if intv, ok := v.(LNumber); ok {

return int(intv)

}

ls.TypeError(n, LTNumber)

return 0

}

func (ls *LState) CheckInt64(n int) int64 {

RainbowMango · 2022-12-08T08:24:57Z

pkg/resourceinterpreter/configurableinterpreter/luavm/kube.go

+func resourceAdd(ls *lua.LState) int {
+	res := resource.Quantity{}
+	n := ls.GetTop()
+	for i := 1; i <= n; i++ {
+		q := checkResourceQuantity(ls, i)
+		res.Add(q)
+	}
+
+	s := res.String()
+	ls.Push(lua.LString(s))
+	return 1
+}


When this function would be used?

Users may want to accurate resource quantity with their logic, rather accuratePodRequirements.

Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>

RainbowMango

/lgtm
/approve

karmada-bot · 2022-12-09T02:56:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [RainbowMango]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 26, 2022

karmada-bot requested review from chaunceyjiang and iawia002 November 26, 2022 17:27

karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2022

ikaven1024 force-pushed the feature/lua-resource branch 2 times, most recently from ada4814 to 081a1d6 Compare November 26, 2022 17:48

RainbowMango added this to the v1.5 milestone Nov 28, 2022

RainbowMango reviewed Nov 28, 2022

View reviewed changes

pkg/resourceinterpreter/configurableinterpreter/luavm/lua_test.go Show resolved Hide resolved

ikaven1024 force-pushed the feature/lua-resource branch 4 times, most recently from 0744a22 to b728378 Compare November 29, 2022 04:42

karmada-bot assigned XiShanYongYe-Chang Dec 2, 2022

XiShanYongYe-Chang reviewed Dec 5, 2022

View reviewed changes

ikaven1024 force-pushed the feature/lua-resource branch from b728378 to 6dd348f Compare December 5, 2022 07:51

karmada-bot assigned RainbowMango Dec 5, 2022

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022

RainbowMango reviewed Dec 8, 2022

View reviewed changes

karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022

ikaven1024 force-pushed the feature/lua-resource branch from b5bdd35 to 3b1a404 Compare December 8, 2022 13:26

add kube lib for lua

0f5e377

Signed-off-by: yingjinhui <yingjinhui@didiglobal.com>

ikaven1024 force-pushed the feature/lua-resource branch from 3b1a404 to 0f5e377 Compare December 8, 2022 14:14

RainbowMango approved these changes Dec 9, 2022

View reviewed changes

karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2022

karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2022

karmada-bot merged commit 54b7aa2 into karmada-io:master Dec 9, 2022

ikaven1024 deleted the feature/lua-resource branch December 9, 2022 02:58

XiShanYongYe-Chang mentioned this pull request Dec 13, 2022

update karmadactl-usage-conventions.md karmada-io/website#274

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add kube lib for lua #2871

add kube lib for lua #2871

ikaven1024 commented Nov 26, 2022 •

edited

Loading

codecov-commenter commented Nov 26, 2022 •

edited

Loading

RainbowMango commented Nov 28, 2022

XiShanYongYe-Chang commented Dec 2, 2022

XiShanYongYe-Chang left a comment

ikaven1024 commented Dec 5, 2022

XiShanYongYe-Chang commented Dec 5, 2022

RainbowMango left a comment

RainbowMango Dec 8, 2022

ikaven1024 Dec 8, 2022

RainbowMango Dec 8, 2022

ikaven1024 Dec 8, 2022

RainbowMango left a comment

karmada-bot commented Dec 9, 2022

	local kube = require("kube")
	function GetReplicas(desiredObj)
	replica = desiredObj.spec.replicas
	requires = kube.accuratePodRequirements(desiredObj.spec.template)
	return replica, requires
	end`,

	func (ls *LState) CheckAny(n int) LValue {
	if n > ls.GetTop() {
	ls.ArgError(n, "value expected")
	}
	return ls.Get(n)
	}

	func (ls *LState) CheckInt(n int) int {
	v := ls.Get(n)
	if intv, ok := v.(LNumber); ok {
	return int(intv)
	}
	ls.TypeError(n, LTNumber)
	return 0
	}

	func (ls *LState) CheckInt64(n int) int64 {

add kube lib for lua #2871

add kube lib for lua #2871

Conversation

ikaven1024 commented Nov 26, 2022 • edited Loading

codecov-commenter commented Nov 26, 2022 • edited Loading

Codecov Report

RainbowMango commented Nov 28, 2022

XiShanYongYe-Chang commented Dec 2, 2022

XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

ikaven1024 commented Dec 5, 2022

XiShanYongYe-Chang commented Dec 5, 2022

RainbowMango left a comment

Choose a reason for hiding this comment

RainbowMango Dec 8, 2022

Choose a reason for hiding this comment

ikaven1024 Dec 8, 2022

Choose a reason for hiding this comment

RainbowMango Dec 8, 2022

Choose a reason for hiding this comment

ikaven1024 Dec 8, 2022

Choose a reason for hiding this comment

RainbowMango left a comment

Choose a reason for hiding this comment

karmada-bot commented Dec 9, 2022

ikaven1024 commented Nov 26, 2022 •

edited

Loading

codecov-commenter commented Nov 26, 2022 •

edited

Loading