-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ResourceInterpreterCustomization ValidatingAdmission #2755
Implement ResourceInterpreterCustomization ValidatingAdmission #2755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2755 +/- ##
==========================================
+ Coverage 33.46% 33.47% +0.01%
==========================================
Files 200 200
Lines 19636 19636
==========================================
+ Hits 6572 6574 +2
+ Misses 12669 12668 -1
+ Partials 395 394 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
A change to a file may have been missed: pkg/karmadactl/cmdinit/karmada/webhook_configuration.go
74a2887
to
ff8676a
Compare
Yes, let's pending this PR first, and we'll deal with this PR after the community has a clearer description of the above issue. |
e474cfa
to
45829d4
Compare
b36ffbb
to
44a917c
Compare
/assign |
2c1896c
to
5be03ca
Compare
5be03ca
to
5befef1
Compare
Shall we check the script in the webhook? Like karmada/pkg/karmadactl/interpret/check.go Lines 83 to 93 in 63a67d7
|
+1 I agree with this point. |
/assign |
5befef1
to
61a5cd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
other parts lgtm
7a472b7
to
8b5d5a3
Compare
a4e0dd8
to
1e5396b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/cc @RainbowMango @ikaven1024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other LGTM
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
1e5396b
to
0c16431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leave LGTM to @XiShanYongYe-Chang @ikaven1024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: chaunceyjiang chaunceyjiang@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
Prevent modifying and creating
ResourceInterpreterCustomization
using the same interpretation rules.Which issue(s) this PR fixes:
Part of #2371
Special notes for your reviewer:
Does this PR introduce a user-facing change?: