fix: tokenClaimAirdrop throws NPE on null sender or receiver (cherry-pick) #17115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation (#16195) Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
…ontract Implementation (#16196) Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
…tleEnabled default to true (#16366) Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
…od implementation (#16443) Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
…16514) Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> Co-authored-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
…tring-as-bytes and actual SHA2-384 hash bytes for Node entries. (#16659) Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com> Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
#16666) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
…ectory (#16753) Signed-off-by: Matt Hess <matt.hess@swirldslabs.com>
…16852) Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
…ansaction Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When submitting a tokenClaimAirdrop transaction, if one of the PendingAirdropIds in the list has an empty senderId or receiverId then the transaction fails catastrophically. This PR fixes the problem and add unit tests and hapi tests to verify the fix.
Related issue(s):
Fixes #17095
This PR is a cherry-pick of PR #17096