-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tokenClaimAirdrop throws NPE on null sender or receiver #17096
fix: tokenClaimAirdrop throws NPE on null sender or receiver #17096
Conversation
…ansaction Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for catching this.
...t-clients/src/main/java/com/hedera/services/bdd/spec/utilops/mod/BodyIdClearingStrategy.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.57 #17096 +/- ##
===============================================
Coverage 63.86% 63.87%
- Complexity 20576 20577 +1
===============================================
Files 2550 2550
Lines 95264 95268 +4
Branches 9952 9952
===============================================
+ Hits 60845 60850 +5
Misses 30802 30802
+ Partials 3617 3616 -1
|
Description:
When submitting a tokenClaimAirdrop transaction, if one of the PendingAirdropIds in the list has an empty
senderId
orreceiverId
then the transaction fails catastrophically. This PR fixes the problem and adds unit tests and hapi tests to verify the fix.Related issue(s):
Fixes #17095
Sister PR to develop: #17097