Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry-Pick Enable HIP-904 System Contracts configuration #16545

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

stoyanov-st
Copy link
Contributor

Description:

This cherry pick PR enables to configuration flags for Airdrops via system contract and removes the current overrides

Related issue(s):

Fixes #16535

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Copy link

github-actions bot commented Nov 12, 2024

Node: HAPI Test (Restart) Results

9 files  1 errors  8 suites   7m 3s ⏱️
7 tests 7 ✅ 0 💤 0 ❌
8 runs  8 ✅ 0 💤 0 ❌

For more details on these parsing errors, see this check.

Results for commit fcb9ee6.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.39%. Comparing base (d749d61) to head (fcb9ee6).
Report is 3 commits behind head on release/0.56.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.56   #16545   +/-   ##
===============================================
  Coverage           58.39%   58.39%           
  Complexity          19999    19999           
===============================================
  Files                2737     2737           
  Lines              100418   100418           
  Branches            10371    10371           
===============================================
  Hits                58640    58640           
  Misses              38147    38147           
  Partials             3631     3631           
Files with missing lines Coverage Δ
...a/com/hedera/node/config/data/ContractsConfig.java 100.00% <ø> (ø)

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d749d61) 100235 62134 61.99%
Head commit (fcb9ee6) 100235 (+0) 62134 (+0) 61.99% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16545) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@povolev15 povolev15 merged commit d5ab465 into release/0.56 Nov 12, 2024
81 of 83 checks passed
@povolev15 povolev15 deleted the hip-904-config-cherry-pick branch November 12, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants