Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase roundsExpired and maxAggregateRels #16567

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

poulok
Copy link
Member

@poulok poulok commented Nov 12, 2024

Related issue(s):

Fixes #16565

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
@poulok poulok added this to the v0.56 milestone Nov 12, 2024
@poulok poulok self-assigned this Nov 12, 2024
@poulok poulok requested review from a team as code owners November 12, 2024 19:27
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.41%. Comparing base (d5ab465) to head (c9992cb).
Report is 1 commits behind head on release/0.56.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.56   #16567      +/-   ##
==================================================
- Coverage           58.41%   58.41%   -0.01%     
+ Complexity          20013    20009       -4     
==================================================
  Files                2738     2738              
  Lines              100484   100484              
  Branches            10381    10381              
==================================================
- Hits                58699    58696       -3     
- Misses              38151    38152       +1     
- Partials             3634     3636       +2     
Files with missing lines Coverage Δ
...java/com/hedera/node/config/data/TokensConfig.java 100.00% <ø> (ø)
...om/swirlds/platform/consensus/ConsensusConfig.java 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d5ab465) 100301 62196 62.01%
Head commit (c9992cb) 100301 (+0) 62195 (-1) 62.01% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16567) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@poulok poulok merged commit fbed355 into release/0.56 Nov 12, 2024
76 checks passed
@poulok poulok deleted the 16565-56-update-config-defaults branch November 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants