Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry-Pick (0.56) HIP 904 SetUnlimitedAutoAssociations System Contract Implementation #16196

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

stoyanov-st
Copy link
Contributor

Description:
Cherry- pick #16141

Related issue(s):
#15592

…tion (#16141)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
@stoyanov-st stoyanov-st added this to the v0.56 milestone Oct 28, 2024
@stoyanov-st stoyanov-st self-assigned this Oct 28, 2024
@stoyanov-st stoyanov-st requested review from a team and tinker-michaelj as code owners October 28, 2024 16:54
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry pick confirmed - LGTM

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (76c54fc) 99989 61887 61.89%
Head commit (dfaf2d5) 100018 (+29) 61916 (+29) 61.90% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16196) 30 30 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.31%. Comparing base (76c54fc) to head (dfaf2d5).
Report is 3 commits behind head on release/0.56.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.56   #16196      +/-   ##
==================================================
+ Coverage           58.29%   58.31%   +0.01%     
- Complexity          19925    19934       +9     
==================================================
  Files                2731     2733       +2     
  Lines              100172   100201      +29     
  Branches            10351    10352       +1     
==================================================
+ Hits                58400    58429      +29     
  Misses              38148    38148              
  Partials             3624     3624              
Files with missing lines Coverage Δ
...act/impl/exec/processors/HasTranslatorsModule.java 100.00% <100.00%> (ø)
...associations/SetUnlimitedAutoAssociationsCall.java 100.00% <100.00%> (ø)
...ations/SetUnlimitedAutoAssociationsTranslator.java 100.00% <100.00%> (ø)
...p/service/contract/impl/state/ProxyEvmAccount.java 91.66% <100.00%> (+0.75%) ⬆️

Impacted file tree graph

@kimbor kimbor changed the title fix: Cherry-Pick (0.56) HIP 904 SetUnlimitedAutoAssociations System Contract Implementaiton fix: Cherry-Pick (0.56) HIP 904 SetUnlimitedAutoAssociations System Contract Implementation Oct 31, 2024
@Nana-EC Nana-EC merged commit 6c6b036 into release/0.56 Nov 1, 2024
67 of 68 checks passed
@Nana-EC Nana-EC deleted the hip-904-set-unlimited-auto-associations branch November 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants