-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HIP 904 SetUnlimitedAutoAssociations System Contract Implementation #16141
feat: HIP 904 SetUnlimitedAutoAssociations System Contract Implementation #16141
Conversation
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16141 +/- ##
=============================================
+ Coverage 58.29% 58.30% +0.01%
- Complexity 19918 19927 +9
=============================================
Files 2731 2733 +2
Lines 100146 100175 +29
Branches 10344 10345 +1
=============================================
+ Hits 58377 58406 +29
Misses 38147 38147
Partials 3622 3622
|
…to-associations # Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/test/java/com/hedera/node/app/service/contract/impl/test/exec/systemcontracts/CallAttemptHelpers.java
...systemcontracts/has/setunlimitedautoassociations/SetUnlimitedAutoAssociationsTranslator.java
Show resolved
Hide resolved
.../exec/systemcontracts/has/setunlimitedautoassociations/SetUnlimitedAutoAssociationsCall.java
Outdated
Show resolved
Hide resolved
…to-associations # Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/test/java/com/hedera/node/app/service/contract/impl/test/exec/systemcontracts/CallAttemptHelpers.java
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tion (#16141) Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
…tion (#16141) Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Description:
This PR aims to implement the SetUnlimitedAutoAssociations system contract described in https://github.com/hashgraph/hedera-services/blob/develop/hedera-node/docs/design/services/smart-contract-service/frictionless-airdrops-system-contracts.md
Related issue(s):
Fixes #15592
Notes for reviewer:
This feature is enabled only for dev and previewnet envs.
Checklist