Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HIP 904 SetUnlimitedAutoAssociations System Contract Implementation #16141

Merged
merged 8 commits into from
Oct 28, 2024

Conversation

stoyanov-st
Copy link
Contributor

Description:
This PR aims to implement the SetUnlimitedAutoAssociations system contract described in https://github.com/hashgraph/hedera-services/blob/develop/hedera-node/docs/design/services/smart-contract-service/frictionless-airdrops-system-contracts.md

Related issue(s):

Fixes #15592

Notes for reviewer:
This feature is enabled only for dev and previewnet envs.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
@stoyanov-st stoyanov-st added this to the v0.56 milestone Oct 24, 2024
@stoyanov-st stoyanov-st self-assigned this Oct 24, 2024
@stoyanov-st stoyanov-st requested review from a team and tinker-michaelj as code owners October 24, 2024 14:28
Copy link

codacy-production bot commented Oct 24, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bbfebec) 99963 61862 61.88%
Head commit (83acb5f) 99992 (+29) 61891 (+29) 61.90% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16141) 30 30 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.30%. Comparing base (bbfebec) to head (83acb5f).
Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #16141      +/-   ##
=============================================
+ Coverage      58.29%   58.30%   +0.01%     
- Complexity     19918    19927       +9     
=============================================
  Files           2731     2733       +2     
  Lines         100146   100175      +29     
  Branches       10344    10345       +1     
=============================================
+ Hits           58377    58406      +29     
  Misses         38147    38147              
  Partials        3622     3622              
Files with missing lines Coverage Δ
...act/impl/exec/processors/HasTranslatorsModule.java 100.00% <100.00%> (ø)
...associations/SetUnlimitedAutoAssociationsCall.java 100.00% <100.00%> (ø)
...ations/SetUnlimitedAutoAssociationsTranslator.java 100.00% <100.00%> (ø)
...p/service/contract/impl/state/ProxyEvmAccount.java 91.66% <100.00%> (+0.75%) ⬆️

Impacted file tree graph

…to-associations

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/test/java/com/hedera/node/app/service/contract/impl/test/exec/systemcontracts/CallAttemptHelpers.java
…to-associations

# Conflicts:
#	hedera-node/hedera-smart-contract-service-impl/src/test/java/com/hedera/node/app/service/contract/impl/test/exec/systemcontracts/CallAttemptHelpers.java
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoyanov-st stoyanov-st merged commit a27fbc1 into develop Oct 28, 2024
51 of 52 checks passed
@stoyanov-st stoyanov-st deleted the 15592-hip-904-set-unlimited-auto-associations branch October 28, 2024 16:33
stoyanov-st added a commit that referenced this pull request Oct 28, 2024
…tion (#16141)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
…tion (#16141)

Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-904: SetUnlimitedAutoAssosiations System Contract
3 participants