-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cherry pick (0.56): isAuthorizedRaw
bug fix
#16405
fix: Cherry pick (0.56): isAuthorizedRaw
bug fix
#16405
Conversation
… key Fix bug for auto-created account. Add a HapiSpec DSL method for creating accounts all four ways they can be created with EC keys. Fixes #15920 Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Also remove unused method in ConversionUtils. Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.56 #16405 +/- ##
===============================================
Coverage 58.34% 58.35%
- Complexity 19959 19964 +5
===============================================
Files 2735 2735
Lines 100292 100307 +15
Branches 10358 10362 +4
===============================================
+ Hits 58518 58535 +17
+ Misses 38149 38148 -1
+ Partials 3625 3624 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
isAuthorizedRaw
bug fixisAuthorizedRaw
bug fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description:
Fixes
isAuthorizedRaw
:Related issue(s):
Fixes #16404
Notes for reviewer:
Cherry picked from commits at PR #16218 (not yet merged to develop at this time)
Checklist