Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cherry pick (0.56): isAuthorizedRaw bug fix #16405

Merged

Conversation

david-bakin-sl
Copy link
Member

Description:

Fixes isAuthorizedRaw:

Fix bug where isAuthorizedRaw fails when given an auto-created account with EC… key

Related issue(s):

Fixes #16404

Notes for reviewer:

Cherry picked from commits at PR #16218 (not yet merged to develop at this time)

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

… key

Fix bug for auto-created account.  Add a HapiSpec DSL method for creating accounts
all four ways they can be created with EC keys.

Fixes #15920

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Also remove unused method in ConversionUtils.

Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>
@david-bakin-sl david-bakin-sl added the Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service. label Nov 4, 2024
@david-bakin-sl david-bakin-sl added this to the v0.56 milestone Nov 4, 2024
@david-bakin-sl david-bakin-sl self-assigned this Nov 4, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 94.44%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f8e9628) 100109 62006 61.94%
Head commit (04e81d6) 100124 (+15) 62022 (+16) 61.95% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16405) 18 17 94.44%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.35%. Comparing base (f8e9628) to head (04e81d6).
Report is 1 commits behind head on release/0.56.

Files with missing lines Patch % Lines
...racts/has/isauthorizedraw/IsAuthorizedRawCall.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.56   #16405   +/-   ##
===============================================
  Coverage           58.34%   58.35%           
- Complexity          19959    19964    +5     
===============================================
  Files                2735     2735           
  Lines              100292   100307   +15     
  Branches            10358    10362    +4     
===============================================
+ Hits                58518    58535   +17     
+ Misses              38149    38148    -1     
+ Partials             3625     3624    -1     
Files with missing lines Coverage Δ
...emcontracts/has/isvalidalias/IsValidAliasCall.java 100.00% <100.00%> (ø)
...p/service/contract/impl/utils/ConversionUtils.java 89.28% <100.00%> (+0.05%) ⬆️
...racts/has/isauthorizedraw/IsAuthorizedRawCall.java 33.67% <0.00%> (+2.04%) ⬆️

Impacted file tree graph

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-bakin-sl david-bakin-sl marked this pull request as ready for review November 4, 2024 17:45
@david-bakin-sl david-bakin-sl changed the title feat: Cherry pick (0.56): isAuthorizedRaw bug fix fix: Cherry pick (0.56): isAuthorizedRaw bug fix Nov 4, 2024
Copy link
Member

@kimbor kimbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kimbor kimbor merged commit 81679f6 into release/0.56 Nov 4, 2024
73 of 74 checks passed
@kimbor kimbor deleted the 16404-cherry-pick-isAuthorizedRaw-bug-fix-to-0.56 branch November 4, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hedera Smart Contract Service Issues related to the Hedera Smart Contract Service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants