Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bug): description field in pom.xml was not populated #16626

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

rbarkerSL
Copy link
Contributor

Description:

The <description></description> field was not present in the pom.xml file generated for maven central. Needed to update two parts of the field setter:

  • .orElse(provider { project.description }) became .orElse(provider(project::getDescription)) to actually populate with the project description
  • .orNull() becomes .orElse("") to prevent a null entry on description if it is not present in the other ways

Related Issue(s):

Fixes #16624

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.) - Tested with gradle pom generation task

**Description**:

The `<description></description>` field was not present in the pom.xml
file generated for maven central. Needed to update two parts of the
field setter:

- `.orElse(provider { project.description })` became
  `.orElse(provider(project::getDescription))` to actually populate with
  the project description
- `.orNull()` becomes `.orElse("")` to prevent a null entry on
  description if it is not present in the other ways

**Related Issue(s)**:

Fixes #16624

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL added Bug An error that causes the feature to behave differently than what was expected based on design. Release Issues tied to release management functions. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. labels Nov 15, 2024
@rbarkerSL rbarkerSL self-assigned this Nov 15, 2024
@rbarkerSL rbarkerSL requested review from a team as code owners November 15, 2024 20:51
@nathanklick nathanklick added this to the v0.56 milestone Nov 15, 2024
@nathanklick nathanklick changed the title fix(bug): description field in pom.xml was not populated build(bug): description field in pom.xml was not populated Nov 15, 2024
@rbarkerSL rbarkerSL merged commit a649547 into develop Nov 15, 2024
43 of 53 checks passed
@rbarkerSL rbarkerSL deleted the 16624-fix-pom-validation-errors branch November 15, 2024 21:00
rbarkerSL added a commit that referenced this pull request Nov 15, 2024
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.32%. Comparing base (eb8b444) to head (b7dc4bb).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16626   +/-   ##
==========================================
  Coverage      63.32%   63.32%           
- Complexity     20140    20149    +9     
==========================================
  Files           2531     2536    +5     
  Lines          94018    94071   +53     
  Branches        9834     9836    +2     
==========================================
+ Hits           59539    59573   +34     
- Misses         30887    30902   +15     
- Partials        3592     3596    +4     

see 23 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eb8b444) 96837 62993 65.05%
Head commit (b7dc4bb) 96838 (+1) 62987 (-6) 65.04% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16626) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

kimbor pushed a commit that referenced this pull request Nov 15, 2024
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. P0 An issue impacting production environments or impacting multiple releases or multiple individuals. Release Issues tied to release management functions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes made to gradle pom generation are breaking maven central publishing
3 participants