-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(bug): description field in pom.xml was not populated #16626
Conversation
**Description**: The `<description></description>` field was not present in the pom.xml file generated for maven central. Needed to update two parts of the field setter: - `.orElse(provider { project.description })` became `.orElse(provider(project::getDescription))` to actually populate with the project description - `.orNull()` becomes `.orElse("")` to prevent a null entry on description if it is not present in the other ways **Related Issue(s)**: Fixes #16624 Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16626 +/- ##
==========================================
Coverage 63.32% 63.32%
- Complexity 20140 20149 +9
==========================================
Files 2531 2536 +5
Lines 94018 94071 +53
Branches 9834 9836 +2
==========================================
+ Hits 59539 59573 +34
- Misses 30887 30902 +15
- Partials 3592 3596 +4 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Description:
The
<description></description>
field was not present in the pom.xml file generated for maven central. Needed to update two parts of the field setter:.orElse(provider { project.description })
became.orElse(provider(project::getDescription))
to actually populate with the project description.orNull()
becomes.orElse("")
to prevent a null entry on description if it is not present in the other waysRelated Issue(s):
Fixes #16624
Checklist