Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase maximums to 100M each by default #16518

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

poulok
Copy link
Member

@poulok poulok commented Nov 9, 2024

Description:
Increases the account and NFT maximums to 100M each.

Related issue(s):

Fixes #16516

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
@poulok poulok added this to the v0.56 milestone Nov 9, 2024
@poulok poulok self-assigned this Nov 9, 2024
@poulok poulok requested a review from a team as a code owner November 9, 2024 01:21
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.39%. Comparing base (1ece16a) to head (d5b6a44).
Report is 1 commits behind head on release/0.56.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.56   #16518   +/-   ##
===============================================
  Coverage           58.39%   58.39%           
  Complexity          19999    19999           
===============================================
  Files                2737     2737           
  Lines              100418   100418           
  Branches            10371    10371           
===============================================
  Hits                58640    58640           
  Misses              38147    38147           
  Partials             3631     3631           
Files with missing lines Coverage Δ
...va/com/hedera/node/config/data/AccountsConfig.java 75.00% <ø> (ø)
...java/com/hedera/node/config/data/TokensConfig.java 100.00% <ø> (ø)

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1ece16a) 100235 62134 61.99%
Head commit (d5b6a44) 100235 (+0) 62134 (+0) 61.99% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16518) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@povolev15 povolev15 changed the title increase maximums to 100M each by default feat: increase maximums to 100M each by default Nov 11, 2024
@povolev15 povolev15 merged commit d749d61 into release/0.56 Nov 11, 2024
63 of 71 checks passed
@povolev15 povolev15 deleted the 16516-56-account-nft-max-100m branch November 11, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants