Added debounce for typeahead search optimization #4904

aashna27 · 2019-03-03T15:15:14Z

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
PR is descriptively titled 📑
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

plotsbot · 2019-03-03T15:27:45Z

	1 Warning
⚠️	New migrations added. Please update `schema.rb.example` by overwriting it with a copy of the up-to-date `db/schema.rb`. Also, be aware to preserve the MySQL-specific conditions for full-text indices.

	2 Messages
📖	@aashna27 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

aashna27 · 2019-03-03T17:06:52Z

@jywarren please have a look I have made the changes as per the issue from codeclimate AtomLinter/linter-eslint#462 referring this link for issue problem but it still persists and I have added debounce as you suggested!!

The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences.

* fixes for map module * yarn.lock update

* updated yarn.lock * tweak

* Simplify username generation * Use status module * Tiny fix * Fix indentation

app/assets/javascripts/debounce.js

* Made moderate buttons to appear on the same line * Removed break tag.

* Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix

* Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try

* Move verification link * Change link to text * Remove unnecessary message

publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in

* First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example

* restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation

* move tag graph button * Update _user_controls.html.erb

* Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes

* add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name

Fixes task mentioned in issue publiclab#4749

Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com>

* Tiny fix * Rubocop

aashna27 · 2019-03-08T18:29:00Z

@jywarren any suggestions?

aashna27 · 2019-03-09T05:08:06Z

Happy to be of help. 😊 Thanks

* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho

aashna27 force-pushed the typeahead-completion branch 2 times, most recently from c8824b5 to af160a5 Compare March 3, 2019 15:41

Added debounce for typeahead search optimization

bdc9497

aashna27 force-pushed the typeahead-completion branch from c7e6893 to bdc9497 Compare March 3, 2019 16:45

Update README.md (publiclab#4883)

d806740

The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences.

aashna27 requested a review from jywarren March 4, 2019 16:24

grvsachdeva and others added 4 commits March 4, 2019 11:58

convert chars to unicode (publiclab#4901)

c8bfed1

fixes for map module (publiclab#4909)

82beb3f

* fixes for map module * yarn.lock update

updated yarn.lock (publiclab#4911)

25213e8

* updated yarn.lock * tweak

Remove useless variable assignment (publiclab#4885)

d19cfcf

* Simplify username generation * Use status module * Tiny fix * Fix indentation

jywarren reviewed Mar 5, 2019

View reviewed changes

app/assets/javascripts/debounce.js Outdated Show resolved Hide resolved

manansingh96 and others added 16 commits March 5, 2019 16:31

Made moderate buttons to appear on the same line (publiclab#4913)

b144b9e

* Made moderate buttons to appear on the same line * Removed break tag.

Clean up (publiclab#4902)

40b6624

* Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix

Move verification link (publiclab#4786)

578cae8

* Move verification link * Change link to text * Remove unnecessary message

popover works, styling is still not showing under elements but is und… (

27b9ecf

publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in

First timer tag script (publiclab#4878)

bb9216b

* First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example

move tag graph button (publiclab#4921)

3013ddf

* move tag graph button * Update _user_controls.html.erb

chore: update README.md (publiclab#4926)

1a9f19c

Fixes task mentioned in issue publiclab#4749

Tiny fix (publiclab#4933)

1493568

* Tiny fix * Rubocop

Update 20190301075323_add_first_tag_poster.rb

1737876

updates (publiclab#4851)

6396287

fix for wiki update (publiclab#4942)

5469e0d

jywarren merged commit 164e349 into publiclab:master Mar 9, 2019

aashna27 deleted the typeahead-completion branch March 9, 2019 18:14

This was referenced Mar 11, 2019

Slow API requests for /api/srch/profiles?query= #4670

Closed

Likes Fix (button mashing and initial negative likes) #4852

Merged

grvsachdeva mentioned this pull request Mar 22, 2019

initial debounced typeahead with debug statements #3172

Closed

sashadev-sky mentioned this pull request May 4, 2019

Weekly Community Check-in #20 - What You Have Learnt publiclab/spectral-workbench#451

Closed

jywarren mentioned this pull request Sep 5, 2019

Don't search for " " (spacebar character) in navbar typeahead search #3409

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added debounce for typeahead search optimization #4904

Added debounce for typeahead search optimization #4904

aashna27 commented Mar 3, 2019 •

edited

Loading

plotsbot commented Mar 3, 2019 •

edited

Loading

aashna27 commented Mar 3, 2019

aashna27 commented Mar 8, 2019

aashna27 commented Mar 9, 2019

Added debounce for typeahead search optimization #4904

Added debounce for typeahead search optimization #4904

Conversation

aashna27 commented Mar 3, 2019 • edited Loading

plotsbot commented Mar 3, 2019 • edited Loading

aashna27 commented Mar 3, 2019

aashna27 commented Mar 8, 2019

aashna27 commented Mar 9, 2019

aashna27 commented Mar 3, 2019 •

edited

Loading

plotsbot commented Mar 3, 2019 •

edited

Loading