Consolidating ranges and stats #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
746a6fe to
ed50515
Compare
Generated by 🚫 Danger |
|
ooooohhhhh Please post some screenshots once you're ready! Thanks Cess this is the biggest one in your project in some ways - the culmination of all your work into a single page type!!!! Great work!!!!! |
|
|
|
OK but let's not sweat the most detailed parts of the design -- let's focus
on first making sure everything is compatible -- for example, I see "over
the past year" on one part of the page, and "since 25 days ago" in another.
Both of these should be sourcing from the user-defined range/period of
time, and should say so. It's possible it's just a labeling issue so far?
But there may be things that need refactoring to properly display for the
given period under the new unified system. This'll be a bit complex so
let's focus on this and we can work on more aesthetic concerns in a
follow-up PR. I hope that makes sense?
Good going Cess!!!!!!
…On Thu, Feb 28, 2019 at 6:12 PM Cess ***@***.***> wrote:
[image: screencapture-localhost-3000-stats-2019-03-01-02_08_25]
<https://user-images.githubusercontent.com/17081074/53604972-1518fa80-3bc7-11e9-808c-461d3ee41009.png>
Here it is @jywarren <https://github.com/jywarren> but I am not quite
satisfied with this. I am working on another design will open another PR so
that we can compare. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5isZIRz_A9l6HQ_8_8egFd2wrWtks5vSGIbgaJpZM4bUBsf>
.
|
|
Oh yeah I see...Yes it makes sense. Thanks |
|
you got it!!!
…On Fri, Mar 1, 2019 at 10:57 AM Cess ***@***.***> wrote:
Oh yeah I see...Yes it makes sense. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ4xSwKBRmm-gLtvpUYW0ALGFrgH2ks5vSU3JgaJpZM4bUBsf>
.
|
03d8233 to
7530778
Compare
|
@jywarren thoughts? |
|
Wow it looks amazing. And it works for any time period selected?
…On Sun, Mar 3, 2019, 6:10 PM Cess ***@***.***> wrote:
@jywarren <https://github.com/jywarren> thoughts?
[image: screencapture-unstable-publiclab-org-stats-2019-03-04-02_01_07]
<https://user-images.githubusercontent.com/17081074/53703389-928c7700-3e22-11e9-9860-eaecd3a31b07.png>
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7SVvbMiZ3MRWXISe48_VXjE8k6Pks5vTFZYgaJpZM4bUBsf>
.
|
|
Any final tests you want to add, or is it good to merge? What do the URLs
look like?
…On Sun, Mar 3, 2019, 6:17 PM Jeffrey Warren ***@***.***> wrote:
Wow it looks amazing. And it works for any time period selected?
On Sun, Mar 3, 2019, 6:10 PM Cess ***@***.***> wrote:
> @jywarren <https://github.com/jywarren> thoughts?
> [image: screencapture-unstable-publiclab-org-stats-2019-03-04-02_01_07]
> <https://user-images.githubusercontent.com/17081074/53703389-928c7700-3e22-11e9-9860-eaecd3a31b07.png>
> Thanks
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4887 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABfJ7SVvbMiZ3MRWXISe48_VXjE8k6Pks5vTFZYgaJpZM4bUBsf>
> .
>
|
|
Yes it does...you can take a look on unstable pushed the code there |
|
The url is now |
|
Oh, yeah let me add a test for the new |
|
While you're making final changes, can I request a couple small things?
1. Can you have the start and end inputs show the current selected period?
2. Is it possible to integrate the quick drop-down of preset ranges? What
was it called, I forget, but it had like past week, past month, past
year... It was great!
3. The filter period is like, to display grouped by week or month? If so, I
think in Shopify stats it's labelled "group by", could we call it that?
Thanks Cess! Tremendous!!!!
…On Sun, Mar 3, 2019, 6:30 PM Cess ***@***.***> wrote:
Oh, yeah let me add a test for the new contribution_graph_making method.
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-GbfyAM_j2gbM2o12ygyD2iK0-oks5vTFrngaJpZM4bUBsf>
.
|
|
|
|
Thanks @jywarren. The |
|
Oh really? When I select from it I get the URL
https://unstable.publiclab.org/stats?utf8=✓&options=Week
Wouldn't it be better to have it set start and end directly? And how does
utf8 get in there?
Also, perhaps if this is the preset ranges we should say "Past week" and
"Past year"?
Thanks Cess!
…On Sun, Mar 3, 2019, 6:51 PM Cess ***@***.***> wrote:
Thanks @jywarren <https://github.com/jywarren>. The filter period is the
previously preset range...should I move it back just before the
date-selector form?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1Krb-hKZOeCoYsXQ2Kb9P_SmBR6ks5vTF_UgaJpZM4bUBsf>
.
|
|
Oh yeah it would make sense to remove the options parameter now and just have start and end set. Thanks fixing that. Will also try and remove the "utf8" not sure how it got there 🤔 |
|
🙌🏽🙌🏽🙌🏽
…On Sun, Mar 3, 2019, 7:06 PM Cess ***@***.***> wrote:
Oh yeah it would make sense to remove the options parameter now and just
have start and end set. Thanks fixing that. Will also try and remove the
"utf8" not sure how it got there 🤔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwaOEy9mMxvN1C5nklgZrwgCqCwZks5vTGNNgaJpZM4bUBsf>
.
|
Change method to create graph based on the range given
1a6255a to
a6bf21a
Compare
a6bf21a to
705b169
Compare
|
@jywarren I managed to remove the |
|
I am using the |
|
OK, that's fine - we can also think about refining the routes and such in a
follow-up. Is this ready to merge, do you think? It's so exciting!!!!
…On Tue, Mar 5, 2019 at 10:56 AM Cess ***@***.***> wrote:
I am using the options param to get what option is selected and set
start_date using it. So if past week is selected I set start_date to Time.now
- 1.week
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4887 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ1EoOg9W2OPTYJdyFKEXx_ZrkX7Tks5vTpOpgaJpZM4bUBsf>
.
|
|
yeah sure will create a follow-up. Yes its ready to merge 😃 |
|
CONGRATS CESS!!!!!! 🎉 🎉 🎉 🎉 |
Closed
|
Awesome work @cesswairimu 🎉 |
|
Thanks @gauravano 😃 |
jywarren
pushed a commit
that referenced
this pull request
Mar 9, 2019
* Added debounce for typeahead search optimization * Update README.md (#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (#4901) * fixes for map module (#4909) * fixes for map module * yarn.lock update * updated yarn.lock (#4911) * updated yarn.lock * tweak * Remove useless variable assignment (#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (#4926) Fixes task mentioned in issue #4749 * Bump cytoscape from 3.4.2 to 3.5.0 (#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (#4851) * fix for wiki update (#4942) * fixes, extend to title suggestions * extended to atwho
icarito
pushed a commit
to icarito/plots2
that referenced
this pull request
Apr 9, 2019
* restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation
icarito
pushed a commit
to icarito/plots2
that referenced
this pull request
Apr 9, 2019
* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Added debounce for typeahead search optimization * Update README.md (publiclab#4883) The "What makes this project different" section had several long sentences which were difficult to understand. I tried to fix this by breaking the sentences down into smaller more concise sentences. * convert chars to unicode (publiclab#4901) * fixes for map module (publiclab#4909) * fixes for map module * yarn.lock update * updated yarn.lock (publiclab#4911) * updated yarn.lock * tweak * Remove useless variable assignment (publiclab#4885) * Simplify username generation * Use status module * Tiny fix * Fix indentation * Made moderate buttons to appear on the same line (publiclab#4913) * Made moderate buttons to appear on the same line * Removed break tag. * Clean up (publiclab#4902) * Clean up with Rubocop * More cleanup * Excluse views * Small refactor * More clean up * Clean up * Fix conflict * Tiny fix * Follow tag asynchronously (publiclab#4587) * Follow tag asynchronously Added link to manage subscriptions Add precondition failed http error code cleanup codeclimate fix Fix typo change remove data-remote Preserve code for non xhr requests Seperate JS and html Codeclimate fix Code Climate fixes Updated tests * Remove pre-compilation of async.js * pre compilation of js assets * cc fix try * Move verification link (publiclab#4786) * Move verification link * Change link to text * Remove unnecessary message * popover works, styling is still not showing under elements but is und… (publiclab#4906) * popover works, styling is still not showing under elements but is under.btn-default * copied yml file back in * First timer tag script (publiclab#4878) * First timer tag script * migration for attaching first-time-poster * change migration bump version to 5.1 * Update schema.rb.example * Consolidating ranges and stats (publiclab#4887) * restyle range page to be a partial * remove static stats * merge range and main stats * render range in main stats * fix failing range test * add questions vs answers graph * add go back and further buttons * minor fixes * Change contribution graph making method Change method to create graph based on the range given * fix failing test and code climate issues * remove commented code and indent * remove stats_nav partial * add contribution graph tests * review requests implemetation * move tag graph button (publiclab#4921) * move tag graph button * Update _user_controls.html.erb * Added reply by tweet feature (publiclab#3175) * Added reply by tweet feature * Updated schedule.rb file * Finalized reply-by-tweet * Corrected schema version * Minor change * Added reply_by_tweet doc * Minor changes * Added twitter gem * Minor changes * Added Environment variables in Docker * Added summery in Doc file * Corrected schema version * Added some documentation * Added some documentation * Migration timestamp changed * Changed migration * Minor change * Minor changes * Added rake to general gem list * Added bundle exec for rake/rails tasks in schedule.rb * Added path env variable * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * MINOR CHANGE * Added print statement to check print * Minor change * Minor change * Changed whenever config * Minor change * Completed reply by tweet feature * Minor change * Minor change * Added gemfile.lock * Update comment.rb * Added gemfile.lock * Minor changes * Minor changes * Minor changes * Minor changes * Add more relevant search results (publiclab#4848) * add helper functions * Modify controller to take extra results * add dict file * add more objects * refactor code and add tests * cc fix * change numbers to account for additions in fixtures * fix tests * remove unused include * code quality fixes * tab fix * changing implementation ideas, removal of unnecessary code * newline fix * cc fix * cc space inside brackets fix * modify query to get rid of redundant words * reduce word to root then tranform * Change file name * chore: update README.md (publiclab#4926) Fixes task mentioned in issue publiclab#4749 * Bump cytoscape from 3.4.2 to 3.5.0 (publiclab#4929) Bumps [cytoscape](https://github.com/cytoscape/cytoscape.js) from 3.4.2 to 3.5.0. - [Release notes](https://github.com/cytoscape/cytoscape.js/releases) - [Commits](cytoscape/cytoscape.js@v3.4.2...v3.5.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Tiny fix (publiclab#4933) * Tiny fix * Rubocop * Update 20190301075323_add_first_tag_poster.rb * updates (publiclab#4851) * fix for wiki update (publiclab#4942) * fixes, extend to title suggestions * extended to atwho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4577
rake test@publiclab/reviewersfor help, in a comment below